fix(ui): keep the model picker from vanishing - #4028
Merged
Conversation
|
😎 This pull request was merged. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "mark settings hydrated after failed rehy..." | Re-trigger Greptile |
|
-- |
charlesvien
force-pushed
the
fix/model-picker-vanishing
branch
from
July 31, 2026 01:59
cdb0eb6 to
1569527
Compare
2 tasks
charlesvien
force-pushed
the
fix/model-picker-vanishing
branch
from
July 31, 2026 02:30
1569527 to
2fa37c4
Compare
There was a problem hiding this comment.
Contained UI bug fix (model picker visibility + rehydration flag) with new unit tests covering every stated scenario; no risky-territory surface touched, and the author has STRONG familiarity with these exact files.
- Author wrote 87% of the modified lines and has 25 merged PRs in these paths (familiarity STRONG).
- 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 138L, 3F substantive, 260L/5F incl. docs/generated/snapshots — within ceiling |
| tier | ✓ | T1-agent / T1c-medium (260L, 5F, single-area, fix) |
| stamphog 2.0.0b3 | .stamphog/policy.yml @ d8556a9 · reviewed head 2fa37c4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since #3821 the merged model/effort pill is the only model picker, and it hides itself whenever its thought-level option is missing. Two ways users lost it:
lastUsedModelpersists the pick, so every composer restores Kimi and hides itself, surviving restarts. Kimi sessions lose the pill too becauseSessionViewonly mounts it when a thought option exists._hasHydrated, sousePreviewConfignever fetches config and the pill never renders. Only clearing app storage fixed it.Changes
ReasoningLevelSelectorrenders a model-only pill for effort-less models (Reasoning submenu and slider hidden, menu opens on Advanced) and shows a disabled Loading placeholder during first load instead of nothing.SessionViewmounts the pill when either the thought or model option exists.settingsStore.onRehydrateStoragehandles the error argument (same pattern aspendingTaskPromptStore) so a failed rehydrate cannot wedge_hasHydrated.How did you test this?
pnpm --filter @posthog/ui test(285 files, 2419 tests) andtsc --noEmitpass.Automatic notifications