Skip to content

chore(desktop): hide custom instructions from task timeline - #4038

Merged
trunk-io[bot] merged 2 commits into
mainfrom
posthog-code/hide-custom-instructions-timeline
Jul 31, 2026
Merged

chore(desktop): hide custom instructions from task timeline#4038
trunk-io[bot] merged 2 commits into
mainfrom
posthog-code/hide-custom-instructions-timeline

Conversation

@tatoalo

@tatoalo tatoalo commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Problem

Saved custom instructions are agent context and should not be exposed in the task activity timeline.

Changes

  • Strip injected custom-instruction blocks from timeline message previews using the existing transcript parser.
  • Add regression coverage for the timeline display.

@trunk-io

trunk-io Bot commented Jul 31, 2026

Copy link
Copy Markdown

😎 Merged successfully - details.

@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit 7a2e2c5.

@tatoalo tatoalo self-assigned this Jul 31, 2026
@tatoalo tatoalo added the Stamphog This will request an autostamp by stamphog on small changes label Jul 31, 2026
@tatoalo
tatoalo marked this pull request as ready for review July 31, 2026 10:39
@tatoalo
tatoalo force-pushed the posthog-code/hide-custom-instructions-timeline branch from 81463b5 to 81e2f27 Compare July 31, 2026 10:40
@tatoalo tatoalo changed the title Hide custom instructions from task timeline chore(desktop): hide custom instructions from task timeline Jul 31, 2026
@tatoalo
tatoalo requested a review from a team July 31, 2026 10:41
@greptile-apps

greptile-apps Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor
Prompt To Fix All With AI
### Issue 1
packages/ui/src/features/canvas/components/ActivityTimeline.tsx:86-90
**Literal instruction tags are removed**

When a user intentionally includes a complete `<user_custom_instructions>...</user_custom_instructions>` example, the new parsing step treats it as injected metadata and removes it, causing the timeline preview to omit legitimate user-authored content.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: 81463b5 | Re-trigger Greptile

Comment thread packages/ui/src/features/canvas/components/ActivityTimeline.tsx
github-actions[bot]
github-actions Bot previously approved these changes Jul 31, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small, test-covered UI display change reusing an already-shipped stripping utility; the unresolved Greptile comment flags a pre-existing edge-case limitation of that shared helper (not a new regression), is cosmetic only, and a human reviewer approved the current head.

  • puemos reviewed the current head.
Gate mechanics and policy version
Gate Result
prerequisites all clear
deny-list no deny categories matched
size 8L, 1F substantive, 26L/2F incl. docs/generated/snapshots — within ceiling
tier T1-agent / T1b-small (26L, 2F, single-area, chore)
stamphog 2.0.0b3 .stamphog/policy.yml @ 32c0189 · reviewed head 81e2f27

Generated-By: PostHog Code
Task-Id: 0d0e7c09-4697-41a1-86b7-f74163356daa
@stamphog
stamphog Bot dismissed github-actions[bot]’s stale review July 31, 2026 10:44

New commits pushed (delta classified non_trivial_delta) — stamphog approval dismissed; re-review running automatically.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small, well-tested UI fix to timeline display logic (no risky territory touched); the reviewer-flagged false-positive stripping issue was fixed with a tighter regex and covered by new regression tests, with no unresolved concerns.

  • 👍 on the PR from greptile-apps[bot].
Gate mechanics and policy version
Gate Result
prerequisites all clear
deny-list no deny categories matched
size 14L, 2F substantive, 63L/5F incl. docs/generated/snapshots — within ceiling
tier T1-agent / T1b-small (63L, 5F, single-area, chore)
stamphog 2.0.0b3 .stamphog/policy.yml @ aa6b6ca · reviewed head 7a2e2c5

@trunk-io
trunk-io Bot merged commit 94c47de into main Jul 31, 2026
33 checks passed
@trunk-io
trunk-io Bot deleted the posthog-code/hide-custom-instructions-timeline branch July 31, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stamphog This will request an autostamp by stamphog on small changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants