fix(provisioner): nest allowDirectSystemCredentials under storageSystemCredentials.aws#591
Merged
Merged
Conversation
…emCredentials.aws #590 set spec.server.storageSystemCredentials.allowDirectSystemCredentials, but the operator CRD nests the AWS flags under .aws (gated by enableAWS): spec.server.storageSystemCredentials.aws.allowDirectSystemCredentials. The wrong-path field is pruned by the API server as unknown, so #590 was a no-op and the "System identity credentials are disabled" error would persist. Found by auditing the warehouse storage profile + CR server config against the operator CRD and Lakekeeper's S3-STS docs. - enableAWS: true (activates the aws credential block) - aws.allowDirectSystemCredentials: true (use Pod Identity creds for S3) - aws.assumeRoleRequireExternalID: false (same-account self-assume needs no external id — preempts the next blocker, since we send no external-id in the storage-credential) Build + provisioner tests green. Needs a CP rebuild to take effect. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Corrects #590, which set the flag at the wrong path. The operator CRD nests the AWS credential flags under
.aws(gated byenableAWS):#590 set
spec.server.storageSystemCredentials.allowDirectSystemCredentials(no.aws). The API server prunes that as an unknown field, so #590 was effectively a no-op — theSystem identity credentials are disablederror would have persisted after its rebuild.How found
Proactive audit of our warehouse storage-profile + CR server config against the operator CRD (
StorageSystemCredentialsConfig→AWSConfig) and Lakekeeper's S3-STS docs, to catch remaining required fields in one pass instead of one rebuild at a time.Fix
assumeRoleRequireExternalID: falseis set explicitly to preempt the next blocker — we send noexternal-idin the storage-credential, so requiring one would fail the warehouse-create.Build +
-tags kubernetesprovisioner tests green. Needs a CP rebuild.🤖 Generated with Claude Code