Skip to content

fix(provisioner): nest allowDirectSystemCredentials under storageSystemCredentials.aws #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fuziontech merged 1 commit into from
May 20, 2026
+11 −3
Merged

fix(provisioner): nest allowDirectSystemCredentials under storageSystemCredentials.aws #591

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions controlplane/provisioner/lakekeeper_k8s.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,10 +326,18 @@ func (c *LakekeeperK8sClient) EnsureCR(ctx context.Context, spec LakekeeperCRSpe
// credentials for S3 — needed so it can assume the
// warehouse's sts-role-arn to vend. Lakekeeper defaults this
// OFF; the operator only emits the enabling env when the
// object is present, so we set it explicitly (a nil parent
// wouldn't pick up the CRD's default=true).
// object is present, so we set it explicitly. The flags live
// under .aws (gated by enableAWS) — a nil parent wouldn't
// pick up the CRD defaults. assumeRoleRequireExternalID is
// false: same-account self-assume needs no external id (and
// requiring one would force an external-id in the
// storage-credential we don't send).
"storageSystemCredentials": map[string]interface{}{
"allowDirectSystemCredentials": true,
"enableAWS": true,
"aws": map[string]interface{}{
"allowDirectSystemCredentials": true,
"assumeRoleRequireExternalID": false,
},
},
},
},
Expand Down
Loading