fix(android): prevent date offset overflow - #714
Merged
Conversation
Contributor
|
Reviews (1): Last reviewed commit: "fix(android): prevent date offset overfl..." | Re-trigger Greptile |
ioannisj
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
PostHogAndroidDateProvidermultiplied second offsets as anIntbefore adding them to a millisecond timestamp. Large offsets could overflow before being converted toLong, producing the wrong date.This changes the multiplication to use
Longarithmetic. It preserves the existing behavior for normal offsets and supports the fullIntrange accepted by the API.💚 How did you test it?
./gradlew :posthog-android:testDebugUnitTest --tests "com.posthog.android.internal.PostHogAndroidDateProviderTest"make checkFormatorigin/main📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Pi implemented the focused arithmetic fix and regression tests after a human-directed Slopo duplication review. Pi autoreview checked the committed branch and reported no actionable findings. The implementation keeps the existing
IntAPI and changes only the intermediate multiplication type.