fix(flags): pass the resolved polling interval to the definitions poll timer#222
Merged
Merged
Conversation
5 tasks
turnipdabeets
approved these changes
Jul 17, 2026
Contributor
flivni
force-pushed
the
polling-interval-default
branch
from
July 17, 2026 20:39
21f8541 to
887a636
Compare
Contributor
Author
|
@turnipdabeets Done — signatures added on both PRs. Can rebase #221 once this one merges. |
turnipdabeets
enabled auto-merge (squash)
July 17, 2026 22:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
feature_flags_polling_intervalis documented as "Defaults to 30" and the poller computes@polling_interval = polling_interval || 30, but the value was not actually used, and the 60-second concurrent-ruby was used instead.This PR fixes the above.
Behavior change worth reviewing: Halves the current effective default. Alternatively, we could update the documented default to 60s.
💚 How did you test it?
execution_interval: 30 when the option is unset, and the configured value when provided. Before the fix, the default case reports 60.rubocopclean.rake public_api:checkpasses with the snapshot regenerated for the one new constant.📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset file🤖 Agent context
Autonomy: Agent-written, human-directed and reviewed
This bug was found by Claude Code (Fable 5) in a code review on a different PR. All code was written by Claude. My contribution is limited to the "Motivation and Context" paragraph and this paragraph here. I've read the code and I fully understand it.