Closed
Conversation
rafaeelaudibert
requested changes
May 14, 2025
Member
rafaeelaudibert
left a comment
rafaeelaudibert
left a comment
There was a problem hiding this comment.
The colon -> rocket change is unusual, we should update the .rubocop.yml file
| api_key: options.api_key, | ||
| api_host: options.api_host, | ||
| on_error: Proc.new { |status, msg| print msg } | ||
| :api_key => options.api_key, |
Member
There was a problem hiding this comment.
Nah, hate this one, can we update the rule? Colon syntax is the modern one, rocket (=>) is antiquated
| @batch = MessageBatch.new(batch_size) | ||
| @lock = Mutex.new | ||
| @transport = Transport.new api_host: options[:host], skip_ssl_verification: options[:skip_ssl_verification] | ||
| @transport = Transport.new :api_host => options[:host], :skip_ssl_verification => options[:skip_ssl_verification] |
Member
There was a problem hiding this comment.
We should tweak the rules to require parenthesis here
Member
Author
|
superseded by #61 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pulling things out of #58 so I can figure out what breaks the tests
this upgrades rubocop
runs autofix
and commits those changes
ignores existing unfixable errors
tests pass before and after