Merged
Conversation
rafaeelaudibert
force-pushed
the
fix/rubocop-v2
branch
from
9bd50bd to
c2a9135
Compare
Let's fix all Rubocop errors. This also uncovered some problems. We're saying in our gemfile we support Ruby 2+ but the code was broken, so fixed it. We should eventually just release a new version limiting us to Ruby 3.2+ (the only supported versions) Syntax will look much simpler too once we can upgrade (can use `&.` for example) I've added Ruby 2.0 to the CI to guarantee we dont break this while we dont bump version
rafaeelaudibert
force-pushed
the
fix/rubocop-v2
branch
from
c2a9135 to
8b6706d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's fix all Rubocop errors. This also uncovered some problems. We're saying in our gemfile we support Ruby 2+ but the code was broken, so fixed it. We should eventually just release a new version limiting us to Ruby 3.2+ (the only supported versions)
Syntax will look much simpler too once we can upgrade (can use
&.for example)I've added Ruby 2.0 to the CI to guarantee we dont break this while we dont bump version