refactor: Simplify bottom-left sidebar section#60370
Conversation
The health tab doesn't need to exist as a separate thing, move it inside "Help" and surface the same errors via the badges like we had before. Also, remove duplicated "Settings" that was present both in the outside and inside "Help"
There was a problem hiding this comment.
This PR exceeded the automated size gate ceiling and has zero reviews. It's a frontend-only refactor merging HealthMenu into HelpMenu, but at 651 lines across 20 files with no reviewer sign-off, it needs at least one human to verify the UI behavior is preserved before auto-approval.
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
frontend/src/lib/components/HelpMenu/HelpMenu.tsx:63-64
`totalIssues` is accessed directly from `healthSummaryLogic` here, but `helpMenuLogic` already connects to `healthSummaryLogic` and exposes `totalIssues` as a connected value. The extra `useValues(healthSummaryLogic)` import in the component is redundant — `totalIssues` can be destructured from `helpMenuLogic` alongside the other badge values it already provides.
```suggestion
const { postHogStatusTooltip, postHogStatusBadgeStatus, postHogStatusBadgeContent } = useValues(posthogStatusLogic)
const { totalIssues, isUnifiedHealthEnabled, triggerBadgeContent, triggerBadgeStatus } = useValues(helpMenuLogic)
```
Reviews (1): Last reviewed commit: "refactor: Simplify bottom-left sidebar s..." | Re-trigger Greptile |
|
Size Change: -3.26 kB (0%) Total Size: 80.2 MB 📦 View Changed
ℹ️ View Unchanged
|
|
✅ Visual changes approved by @rafaeelaudibert — baseline updated in 20 changed. |
e4adb6d to
e0e86f4
Compare
f55953d to
e02218e
Compare
|
🎭 Playwright didn't run on this PR — your changes touch code that could affect E2E behavior, but Playwright is opt-in via label now to keep CI cost down. Add the Most PRs don't need this. Real regressions still get caught on master and fix-forward. |
e02218e to
f55953d
Compare
e0e86f4 to
ff7384d
Compare
f55953d to
155e88d
Compare
155e88d to
1681eb4
Compare
20 updated Run: 4da673f3-a889-477e-85c3-8e981f4ea01a Co-authored-by: rafaeelaudibert <32079912+rafaeelaudibert@users.noreply.github.com>
|
🎭 Playwright report · View test results →
These issues are not necessarily caused by your changes. |
484a4c7 to
1416607
Compare
Merge activity
|

The
HealthMenucomponent and its associated logic have been consolidated into theHelpMenu. Rather than maintaining a separate menu entry in the nav bar footer, health status information (PostHog platform status, health issue counts, and badge indicators) is now surfaced directly within the Help menu.Key changes:
HealthMenucomponent and itshealthMenuLogic, replacing them withposthogStatusLogic(extracted status selectors) andhealthSummaryLogic(renamed fromunifiedHealthMenuLogic, with badge selectors moved up tohelpMenuLogic)g hkeyboard shortcut for toggling the health menuincidentStatusLogictypes to remove theIncidentIoprefix, and renamed mock fixture files and theINCIDENT_IO_STATUS_PAGE_BASEconstant to remove vendor-specific namingPosthogStatusShownOnlyIfNotOperationalcomponent now sources its values fromposthogStatusLogicinstead ofhealthMenuLogic