chore(settings): reorder settings map entries alphabetically#60372
Merged
Conversation
The order here was just insane, let's put the house in order
rafaeelaudibert
requested review from
a team,
MattBro and
fercgomes
and removed request for
a team
This was referenced May 27, 2026
Member
Author
![stamphog[bot]](https://avatars.githubusercontent.com/in/3000332?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is a large mechanical alphabetical reorder of settings map entries across two files (768 lines changed). While the change appears purely cosmetic/organizational, the size gate failed and there are zero reviews. A human should verify no settings entries were accidentally dropped or duplicated in the reorder.
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
frontend/src/scenes/settings/SettingsMap.tsx:358-360
This PR is described as a pure alphabetical reorder, but `group: 'Products'` is added here for the first time on `environment-csp-reporting`. No other section in the diff adds a new `group` value — all the others with `group` already had it before. This will change the sidebar grouping for CSP reporting. If intentional, it should be called out in the PR description; if not, it should be reverted.
```suggestion
id: 'environment-csp-reporting',
title: 'CSP reporting',
```
Reviews (1): Last reviewed commit: "refactor: Reorder settings" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
358
to
+360
| id: 'environment-csp-reporting', | ||
| title: 'CSP reporting', | ||
| group: 'Products', |
Contributor
There was a problem hiding this comment.
group: 'Products' is added here for the first time on environment-csp-reporting. No other section in the diff adds a new group value — all the others with group already had it before. This will change the sidebar grouping for CSP reporting. If intentional, it should be called out in the PR description; if not, it should be reverted.
Suggested change
| id: 'environment-csp-reporting', | |
| title: 'CSP reporting', | |
| group: 'Products', | |
| id: 'environment-csp-reporting', | |
| title: 'CSP reporting', |
Prompt To Fix With AI
This is a comment left during a code review.
Path: frontend/src/scenes/settings/SettingsMap.tsx
Line: 358-360
Comment:
This PR is described as a pure alphabetical reorder, but `group: 'Products'` is added here for the first time on `environment-csp-reporting`. No other section in the diff adds a new `group` value — all the others with `group` already had it before. This will change the sidebar grouping for CSP reporting. If intentional, it should be called out in the PR description; if not, it should be reverted.
```suggestion
id: 'environment-csp-reporting',
title: 'CSP reporting',
```
How can I resolve this? If you propose a fix, please make it concise.
Contributor
|
Size Change: 0 B Total Size: 80.7 MB ℹ️ View Unchanged
|
Contributor
|
✅ Visual changes approved by @rafaeelaudibert — baseline updated in 96 changed. |
rafaeelaudibert
force-pushed
the
rafa/09-reorder-settings
branch
from
dd0c982 to
6469a81
Compare
rafaeelaudibert
force-pushed
the
rafa/08-move-exports-away
branch
2 times, most recently
from
04c02a2 to
0614a55
Compare
Contributor
|
🎭 Playwright didn't run on this PR — your changes touch code that could affect E2E behavior, but Playwright is opt-in via label now to keep CI cost down. Add the Most PRs don't need this. Real regressions still get caught on master and fix-forward. |
rafaeelaudibert
force-pushed
the
rafa/09-reorder-settings
branch
2 times, most recently
from
f4c3f45 to
4c84923
Compare
rafaeelaudibert
force-pushed
the
rafa/08-move-exports-away
branch
2 times, most recently
from
089897a to
ba6c0de
Compare
rafaeelaudibert
force-pushed
the
rafa/09-reorder-settings
branch
from
4c84923 to
befe210
Compare
rafaeelaudibert
force-pushed
the
rafa/08-move-exports-away
branch
from
ba6c0de to
d646615
Compare
rafaeelaudibert
force-pushed
the
rafa/09-reorder-settings
branch
from
befe210 to
5643796
Compare
MattBro
approved these changes
May 28, 2026
Contributor
MattBro
left a comment
MattBro
left a comment
There was a problem hiding this comment.
LGTM. Two alphabetization gaps inline.
| }, | ||
| { | ||
| level: 'organization', | ||
| id: 'organization-proxy', |
Contributor
There was a problem hiding this comment.
nit: PR description states the goal is alphabetical ordering within each level, but organization-proxy (line 1570) sits ahead of organization-members (1584) and organization-oauth-apps (1605). types.ts (lines 68-70) has the union in the correct alphabetical order (members, oauth-apps, proxy). Move organization-proxy down after organization-oauth-apps to match.
| }, | ||
| { | ||
| level: 'user', | ||
| id: 'user-personal-integrations', |
Contributor
There was a problem hiding this comment.
nit: same alphabetization gap at the user level. user-api-keys (line 1842) sits 6th between notifications and personal-integrations, but types.ts:77 puts it 2nd right after user-profile. Anchoring on the nearest diff line; the target is user-api-keys above.
rafaeelaudibert
force-pushed
the
rafa/08-move-exports-away
branch
from
34968a6 to
05f317d
Compare
rafaeelaudibert
force-pushed
the
rafa/09-reorder-settings
branch
from
5643796 to
cea5c40
Compare
rafaeelaudibert
changed the base branch from
rafa/08-move-exports-away
to
graphite-base/60372
rafaeelaudibert
force-pushed
the
rafa/09-reorder-settings
branch
from
cea5c40 to
ddc5b8a
Compare
rafaeelaudibert
force-pushed
the
graphite-base/60372
branch
from
05f317d to
4688583
Compare
rafaeelaudibert
force-pushed
the
rafa/09-reorder-settings
branch
from
ddc5b8a to
4c5d6e7
Compare
rafaeelaudibert
force-pushed
the
rafa/09-reorder-settings
branch
from
4c5d6e7 to
9b44a0d
Compare
96 updated Run: 25c7125e-f2fc-456c-a919-0949614bba18 Co-authored-by: rafaeelaudibert <32079912+rafaeelaudibert@users.noreply.github.com>
Contributor
|
🎭 Playwright report · View test results →
These issues are not necessarily caused by your changes. |
rorylshanks
pushed a commit
that referenced
this pull request
May 29, 2026
Reorder settings sections in `SettingsMap` and `types.ts` so that all section IDs and setting IDs are listed alphabetically within their respective levels (environment, project, organization, user). This makes it easier to locate and reason about where a given setting lives, and reduces the chance of accidentally duplicating or misplacing entries when adding new ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorder settings sections in
SettingsMapandtypes.tsso that all section IDs and setting IDs are listed alphabetically within their respective levels (environment, project, organization, user). This makes it easier to locate and reason about where a given setting lives, and reduces the chance of accidentally duplicating or misplacing entries when adding new ones.