feat(warehouse-sources): add catalog search aliases for connector alternate names - #70294
Conversation
… found by alternate names Users browsing the new-source catalog search for connectors by an alternate name and come up empty: "fb"/"facebook" doesn't surface Meta Ads (the search only knew "facebook ads"/"instagram ads"), and "sql" doesn't surface the relational database sources. Add the missing lowercase keyword aliases to the affected source configs: - Meta Ads: facebook, instagram, fb - Postgres: sql - MySQL: sql, mariadb (the connector already handles MariaDB) - MSSQL: sql, mssql These flow through the existing `keywords` field into the catalog's Fuse search — no search-plumbing change needed. Generated-By: PostHog Code Task-Id: 39d9ec17-acb3-486d-ba03-e733fba10d18
|
Hey @Gilbert09! 👋 It looks like your git author email on this PR isn't your
You can fix it for this repo with: git config user.email "you@posthog.com"Or set it globally with |
|
Reviews (1): Last reviewed commit: "feat(warehouse-sources): add catalog sea..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![stamphog[bot]](https://avatars.githubusercontent.com/in/3000332?s=60&v=4){kind=small}
There was a problem hiding this comment.
Purely additive search-keyword data change to the connector catalog, outside risky territory, by an owning-team author with strong familiarity; the sole reviewer concern was addressed and acknowledged.
- Author wrote 100% of the modified lines and has 50 merged PRs in these paths (familiarity STRONG).
- Gilbert09, greptile-apps[bot] reviewed the current head.
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 7L, 4F substantive — within ceiling |
| tier | ✓ | T1-agent / T1b-small (7L, 4F, single-area, feat) |
| stamphog 2.0.0b3 | .stamphog/policy.yml @ dc71029 · reviewed head 05a5df6 |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
1 participant
Problem
Session-replay observations of real users in the data-warehouse new-source onboarding flow show people searching the connector catalog by an alternate name and finding nothing:
facebook ads/instagram ads, so a short query likefb(and even barefacebook) didn't match, and the connector stayed hidden.postgresql, MySQL had no keywords, and MSSQL only hadsql server, so a baresqlquery didn't reliably surface any of them.The catalog already supports search aliases via each source's
keywordslist (indexed by the Fuse search alongside name/label/category) — the affected connectors were just missing the obvious ones.Changes
Add the missing lowercase keyword aliases:
facebook,instagram,fbsqlsql,mariadb(the connector already handles MariaDB credentials)sql,mssqlNo search-plumbing change — these feed the existing
keywordsfield.How did you test this code?
The Python toolchain isn't bootstrapped in this sandbox, so I couldn't run the suite locally; CI will run it. The change is pure data — lowercase strings appended to existing
keywordslists — which satisfies the existing format check intest_source_categories.py::test_source_keywords_are_a_list_of_strings(asserts every keyword is a lowercase string). Ruff check + format pass on all four files.Docs update
No docs update needed.
🤖 Agent context
Autonomy: Fully autonomous
Authored by Claude Code (Opus 4.8) from Replay Vision observations of the data-warehouse onboarding flow. The friction ("users can't find a connector by the name they search") recurred across sessions; this is the self-contained, low-risk slice. Deeper themes (OAuth transient-error copy, Google Ads MCC-vs-client ID hinting) were left as recommendations since existing maintainer PRs already cover that ground.
Created with PostHog Code