fix(eng-analytics): improve flaky test leaderboard - #70464
Conversation
🤖 CI report
|
| File | Size | Δ vs base |
|---|---|---|
posthog-app/src/scenes/inbox/InboxScene.js |
651.2 KiB | 🔺 +1.9 KiB (+0.3%) |
render-query/src/render-query/render-query.js |
21.20 MiB | 🔺 +1.4 KiB (+0.0%) |
posthog-app/src/scenes/AuthenticatedShell.js |
219.6 KiB | 🔺 +1.3 KiB (+0.6%) |
Posted automatically by build-bundle-size-report · uncompressed bytes from dist-report
✅ Eager graph — within budget
How much code each root ships on the eager path — downloaded and parsed before the surface is interactive. Measured from the esbuild output chunks (post-tree-shake, static imports only); lazy import() / React.lazy chunks are not counted.
| Root | Eager (shipped) | Δ vs base | Budget |
|---|---|---|---|
entry (logged-out pages, app bootstrap)src/index.tsx |
1.21 MiB · 22 files | 🔺 +384 B (+0.0%) | ███░░░░░░░ 28.1% of 4.29 MiB |
authenticated shell (every logged-in page)src/scenes/AuthenticatedShell.tsx |
8.10 MiB · 2,973 files | 🔺 +7.3 KiB (+0.1%) | █████████░ 87.6% of 9.25 MiB |
🟢 node_modules/monaco-editor/ stays out of src/index.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/index.tsx
🟢 [object Object] stays out of src/index.tsx
🟢 [object Object] stays out of src/index.tsx
🟢 node_modules/monaco-editor/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
Largest files eagerly shipped from src/index.tsx
| Size | File |
|---|---|
| 126.8 KiB | ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js |
| 24.6 KiB | ../node_modules/.pnpm/buffer@6.0.3/node_modules/buffer/index.js |
| 6.3 KiB | ../node_modules/.pnpm/react@18.3.1/node_modules/react/cjs/react.production.min.js |
| 4.5 KiB | ../node_modules/.pnpm/@jspm+core@2.1.0/node_modules/@jspm/core/nodelibs/browser/process.js |
| 3.9 KiB | ../node_modules/.pnpm/scheduler@0.23.2/node_modules/scheduler/cjs/scheduler.production.min.js |
| 1.4 KiB | ../node_modules/.pnpm/base64-js@1.5.1/node_modules/base64-js/index.js |
| 1.3 KiB | src/RootErrorBoundary.tsx |
| 912 B | ../node_modules/.pnpm/ieee754@1.2.1/node_modules/ieee754/index.js |
| 789 B | src/scenes/ChunkLoadErrorBoundary.tsx |
| 668 B | src/index.tsx |
Largest files eagerly shipped from src/scenes/AuthenticatedShell.tsx
| Size | File |
|---|---|
| 278.6 KiB | ../node_modules/.pnpm/posthog-js@1.399.2/node_modules/posthog-js/dist/rrweb.js |
| 267.7 KiB | ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js |
| 234.9 KiB | src/taxonomy/core-filter-definitions-by-group.json |
| 221.5 KiB | ../node_modules/.pnpm/posthog-js@1.399.2/node_modules/posthog-js/dist/module.js |
| 164.0 KiB | src/queries/validators.js |
| 154.3 KiB | ../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js |
| 126.8 KiB | ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js |
| 105.9 KiB | src/lib/api.ts |
| 93.3 KiB | ../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js |
| 90.6 KiB | ../node_modules/.pnpm/@tiptap+core@3.20.6_@tiptap+pm@3.20.6/node_modules/@tiptap/core/dist/index.js |
Posted automatically by check-eager-graph · sizes are eager output bytes (shipped, post-tree-shake) from the esbuild metafile · part of #32479
⚠️ Dist folder size — 🔺 +174.9 KiB (+0.0%)
Total size of the built frontend/dist folder (all assets), compared against the base branch.
Total: 1278.74 MiB · 🔺 +174.9 KiB (+0.0%)
|
✅ Visual changes approved by @rnegron — baseline updated in 2 changed. |
🦔 Hogbox preview · ✅ ready▶ Open the preview
commit |
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![stamphog[bot]](https://avatars.githubusercontent.com/in/3000332?s=60&v=4){kind=small}
There was a problem hiding this comment.
The security concern Greptile flagged (repository filter failing open) is directly fixed in this diff — it now fails closed and returns no rows plus a dedicated regression test — and the change is by a STRONG-familiarity author on the owning team for an internal analytics dashboard, not risky-territory production code.
- Author wrote 100% of the modified lines and has 48 merged PRs in these paths (familiarity STRONG).
- 👍 on the PR from greptile-apps[bot], hex-security-app[bot].
- Unresolved P2 comment from Greptile: sorting the leaderboard only reorders the capped 200-row fetch, which can present an incomplete sort as if it covers the full result set — cosmetic/UX nit, not a correctness or safety issue.
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 66L, 5F substantive, 113L/10F incl. docs/generated/snapshots — within ceiling |
| tier | ✓ | T1-agent / T1c-medium (113L, 10F, two-areas, fix) |
| stamphog 2.0.0b3 | .stamphog/policy.yml @ 9c7cb39 · reviewed head 1fd27f3 |
2 updated Run: 69f068ce-1585-4e95-839d-68721ea159b2 Co-authored-by: rnegron <4153103+rnegron@users.noreply.github.com>
New commits pushed (delta classified non_trivial_delta) — stamphog approval dismissed; re-review running automatically.
There was a problem hiding this comment.
This is a targeted fix for a real cross-repository data-scoping bug in an internal test-flakiness dashboard; the diff includes the fail-closed guard and a dedicated regression test (test_source_without_repository_fails_closed) that directly covers the exact issue Greptile flagged on an earlier commit, and the author has STRONG familiarity with 93% of the touched lines on the owning team. The remaining open review note (sort only covering the fetched page) is a minor UX quibble, not a correctness or security showstopper.
- Author wrote 93% of the modified lines and has 59 merged PRs in these paths (familiarity STRONG).
- 👍 on the PR from greptile-apps[bot], hex-security-app[bot].
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 70L, 6F substantive, 117L/11F incl. docs/generated/snapshots — within ceiling |
| tier | ✓ | T1-agent / T1d-complex (117L, 11F, cross-cutting, fix) |
| stamphog 2.0.0b3 | .stamphog/policy.yml @ b864e6b · reviewed head 022c975 |
1 participant
Problem
The flaky-test leaderboard showed too many rows initially and could mix CI trace signals from different repositories connected to one project.
Changes
How did you test this code?
Automatic notifications
Docs update
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
I used Codex desktop with
/wt,/source-command-conventions,/writing-tests,/run-posthog,/running-ci-preflight, and Browser. I kept LemonTable to match the main-app component boundary and added repository scoping after tracing the OTLP data path.