Skip to content

fix(devex): widen build:openapi triggers to all MCP inputs - #70519

Merged
rnegron merged 1 commit into
masterfrom
devex/openapi-trigger-mcp-inputs
Jul 13, 2026
Merged

fix(devex): widen build:openapi triggers to all MCP inputs#70519
rnegron merged 1 commit into
masterfrom
devex/openapi-trigger-mcp-inputs

Conversation

@rnegron

@rnegron rnegron commented Jul 13, 2026

Copy link
Copy Markdown
Member

Problem

  • hogli build and hogli ci:preflight share BUILD_TRIGGERS["build:openapi"], but it misses three MCP codegen inputs that CI's openapi_types filter already fires on
  • Editing an MCP prompt, a non-tools.yaml MCP config, or the handwritten tool definitions passes preflight locally, then fails check-openapi-types in CI (or lands a surprise auto-commit)

Changes

  • products/*/mcp/tools.yaml widened to products/*/mcp/*.yaml (4 sibling YAMLs exist today)
  • Add products/*/mcp/prompts/* (22 description_file: sources) and services/mcp/schema/tool-definitions.json (handwritten input read by generate-tools.ts)
  • Generator outputs and products/*/mcp/apps/** stay excluded, so no rebuild loops
  • ci_preflight.py inherits the change through the shared tuple

How did you test this code?

  • fnmatch check over 11 representative paths (new inputs match, generated outputs and MCP UI apps do not, existing entries unchanged), ruff clean

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Docs update

None needed.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

  • Claude Code validated the gap against generate-tools.ts read sites before editing, then verified glob coverage with fnmatch (same semantics as matches_globs)
  • Heads up: feat(devex): distributed owners.yaml ownership with a single resolver #68872 also edits this tuple (scopes the api/* entries to *.py), different lines so an easy rebase either way
  • Side note found while validating: the CI filter lists services/mcp/schema/tool-definitions-v2.json, which no longer exists in the repo

@rnegron rnegron self-assigned this Jul 13, 2026
@trunk-io

trunk-io Bot commented Jul 13, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@rnegron
rnegron marked this pull request as ready for review July 13, 2026 17:55
@rnegron rnegron added the stamphog Request AI approval (no full review) label Jul 13, 2026
@rnegron
rnegron enabled auto-merge (squash) July 13, 2026 17:56
@pr-assigner-resolver-posthog
pr-assigner-resolver-posthog Bot requested a review from a team July 13, 2026 17:56
@greptile-apps

greptile-apps Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "fix(devex): widen build:openapi triggers..." | Re-trigger Greptile

@stamphog stamphog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial dev-tooling change widening build trigger globs for internal CLI; no production code, API, or CI security surface touched, and matches its description. Author is on owning team with strong familiarity.

  • Author wrote 100% of the modified lines and has 35 merged PRs in these paths (familiarity STRONG).
  • 👍 on the PR from greptile-apps[bot], hex-security-app[bot].
Gate mechanics and policy version
Gate Result
prerequisites all clear
deny-list no deny categories matched
size 4L, 1F substantive — within ceiling
tier T1-agent / T1a-trivial (4L, 1F, single-area, fix)
stamphog 2.0.0b3 .stamphog/policy.yml @ 1198161 · reviewed head 01a7bee

@rnegron
rnegron merged commit bd7a7a7 into master Jul 13, 2026
286 of 319 checks passed
@rnegron
rnegron deleted the devex/openapi-trigger-mcp-inputs branch July 13, 2026 18:02
@deployment-status-posthog

deployment-status-posthog Bot commented Jul 13, 2026

Copy link
Copy Markdown

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-07-13 18:27 UTC Run
prod-us ✅ Deployed 2026-07-13 18:38 UTC Run
prod-eu ✅ Deployed 2026-07-13 18:40 UTC Run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stamphog Request AI approval (no full review)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant