fix(tracing): match the facet rail toggle to the logs display bar - #70748
Conversation
The tracing rail toggle was an icon-only secondary button with a tooltip; logs renders a labeled default button. Use the same treatment and the same "Show filters"/"Hide filters" copy so the two viewers read identically. Generated-By: PostHog Code Task-Id: 6ee59ceb-1203-4d45-9184-346ef33e3b1e
🤖 CI report✅ Bundle size — 🟢 -12 B (-0.0%)Uncompressed size of every built Total: 64.77 MiB · 🟢 -12 B (-0.0%) No file changed by more than 1000 B. Posted automatically by build-bundle-size-report · uncompressed bytes from dist-report ✅ Eager graph — within budgetHow much code each root ships on the eager path — downloaded and parsed before the surface is interactive. Measured from the esbuild output chunks (post-tree-shake, static imports only); lazy
🟢 Largest files eagerly shipped from
|
| Size | File |
|---|---|
| 126.8 KiB | ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js |
| 24.6 KiB | ../node_modules/.pnpm/buffer@6.0.3/node_modules/buffer/index.js |
| 6.3 KiB | ../node_modules/.pnpm/react@18.3.1/node_modules/react/cjs/react.production.min.js |
| 4.5 KiB | ../node_modules/.pnpm/@jspm+core@2.1.0/node_modules/@jspm/core/nodelibs/browser/process.js |
| 3.9 KiB | ../node_modules/.pnpm/scheduler@0.23.2/node_modules/scheduler/cjs/scheduler.production.min.js |
| 1.4 KiB | ../node_modules/.pnpm/base64-js@1.5.1/node_modules/base64-js/index.js |
| 1.3 KiB | src/RootErrorBoundary.tsx |
| 912 B | ../node_modules/.pnpm/ieee754@1.2.1/node_modules/ieee754/index.js |
| 789 B | src/scenes/ChunkLoadErrorBoundary.tsx |
| 762 B | src/index.tsx |
Largest files eagerly shipped from src/scenes/AuthenticatedShell.tsx
| Size | File |
|---|---|
| 281.1 KiB | ../node_modules/.pnpm/posthog-js@1.401.0/node_modules/posthog-js/dist/rrweb.js |
| 267.7 KiB | ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js |
| 235.5 KiB | src/taxonomy/core-filter-definitions-by-group.json |
| 222.7 KiB | ../node_modules/.pnpm/posthog-js@1.401.0/node_modules/posthog-js/dist/module.js |
| 164.0 KiB | src/queries/validators.js |
| 154.3 KiB | ../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js |
| 126.8 KiB | ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js |
| 106.1 KiB | src/lib/api.ts |
| 93.3 KiB | ../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js |
| 92.7 KiB | ../packages/quill/packages/quill/dist/index.js |
Posted automatically by check-eager-graph · sizes are eager output bytes (shipped, post-tree-shake) from the esbuild metafile · part of #32479
✅ Dist folder size — 🟢 -35 B (-0.0%)
Total size of the built frontend/dist folder (all assets), compared against the base branch.
Total: 1307.94 MiB · 🟢 -35 B (-0.0%)
🦔 Hogbox preview · ✅ ready▶ Open the preview
commit |
👀 Auto-assigned reviewersThese soft owners were skipped because they only have minor changes here. Nothing blocks merge, so self-assign if you'd like a look:
Soft owners come from |
|
Reviews (1): Last reviewed commit: "fix(tracing): match the facet rail toggl..." | Re-trigger Greptile |
Generated-By: PostHog Code Task-Id: 7eeea8df-accb-486b-a1e5-b37aea35a1d4
|
👋 Visual changes detected for this PR. Review and approve in PostHog Visual Review If these changes are unexpected, they may be caused by a flaky test or a broken snapshot on master. Don't approve — rerun the job or wait for a fix. |
Generated-By: PostHog Code Task-Id: dd96a2e9-24f8-4f2f-8509-83bf54304cbd
|
CI is green. One note for reviewers: the This is a pre-existing flake unrelated to this PR — this branch only touches 🦉 via talyn.dev |
There was a problem hiding this comment.
Trivial, flag-gated style-only change with no behavior impact; author has strong familiarity with this code covering the cross-team gap.
- Author wrote 100% of the modified lines and has 45 merged PRs in these paths (familiarity STRONG).
- 👍 on the PR from greptile-apps[bot], hex-security-app[bot].
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 8L, 1F substantive — within ceiling |
| tier | ✓ | T1-agent / T1a-trivial (8L, 1F, single-area, fix) |
| stamphog 2.0.0b3 | .stamphog/policy.yml @ 11b7d38 · reviewed head 818ab6f |
Generated-By: PostHog Code Task-Id: 4ceae262-01fd-4adf-b5f8-695eeb68e564
Generated-By: PostHog Code Task-Id: 1c85c7b7-38df-41a2-a47a-bcd1746a1a24
|
Update: green after merging master. The visual review initially flagged one changed snapshot — That snapshot is a known flaky one: its change history shows it flipping between 🦉 via talyn.dev |
Problem
The tracing scene's facet rail toggle is an icon-only secondary button with a "Show facets" tooltip, while the logs viewer renders a labeled default button reading "Show filters"/"Hide filters". The two viewers share the same layout (filter bar, sparkline, rail, display bar), so the same control looking different in each is unnecessary friction for anyone using both.
Changes
Restyle the toggle in
TracingDisplayBar.tsxto the exact logs treatment: default (tertiary)LemonButtonwith a visible "Show filters"/"Hide filters" label next to the chevron, tooltip dropped since the label now says the same thing. Copy switches from "facets" to "filters" to match logs. Thedata-attris unchanged.Behind the
TRACING_FACET_RAILflag, so no user-visible change until rollout.How did you test this code?
Style-only JSX change to an existing flag-gated button, mirroring the exact
LemonButtonusage already shipped inLogsDisplayBar.tsx. No behavior change, so no new tests. I didn't manually test this in a browser.Automatic notifications
Docs update
Not needed, internal flag-gated UI.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Authored by Claude (PostHog Code session) at Jon's direction to bring the tracing rail toggle to parity with logs. The change copies the button markup from
LogsDisplayBar.tsxverbatim, adjusted for tracing's logic/action names. No skills beyond repo conventions were involved.Created with PostHog Code