Skip to content

fix(tracing): match the facet rail toggle to the logs display bar - #70748

Merged
jonmcwest merged 5 commits into
masterfrom
posthog-code/tracing-facet-rail-toggle-parity
Jul 15, 2026
Merged

fix(tracing): match the facet rail toggle to the logs display bar#70748
jonmcwest merged 5 commits into
masterfrom
posthog-code/tracing-facet-rail-toggle-parity

Conversation

@jonmcwest

Copy link
Copy Markdown
Contributor

Problem

The tracing scene's facet rail toggle is an icon-only secondary button with a "Show facets" tooltip, while the logs viewer renders a labeled default button reading "Show filters"/"Hide filters". The two viewers share the same layout (filter bar, sparkline, rail, display bar), so the same control looking different in each is unnecessary friction for anyone using both.

Changes

Restyle the toggle in TracingDisplayBar.tsx to the exact logs treatment: default (tertiary) LemonButton with a visible "Show filters"/"Hide filters" label next to the chevron, tooltip dropped since the label now says the same thing. Copy switches from "facets" to "filters" to match logs. The data-attr is unchanged.

Behind the TRACING_FACET_RAIL flag, so no user-visible change until rollout.

How did you test this code?

Style-only JSX change to an existing flag-gated button, mirroring the exact LemonButton usage already shipped in LogsDisplayBar.tsx. No behavior change, so no new tests. I didn't manually test this in a browser.

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Docs update

Not needed, internal flag-gated UI.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Authored by Claude (PostHog Code session) at Jon's direction to bring the tracing rail toggle to parity with logs. The change copies the button markup from LogsDisplayBar.tsx verbatim, adjusted for tracing's logic/action names. No skills beyond repo conventions were involved.


Created with PostHog Code

The tracing rail toggle was an icon-only secondary button with a tooltip;
logs renders a labeled default button. Use the same treatment and the same
"Show filters"/"Hide filters" copy so the two viewers read identically.

Generated-By: PostHog Code
Task-Id: 6ee59ceb-1203-4d45-9184-346ef33e3b1e
@jonmcwest jonmcwest added the skip-agent-review Save $$$, skip auto agent reviews (Greptile) — use for trivial or chore PRs label Jul 14, 2026
@jonmcwest jonmcwest self-assigned this Jul 14, 2026
@jonmcwest jonmcwest added the skip-agent-review Save $$$, skip auto agent reviews (Greptile) — use for trivial or chore PRs label Jul 14, 2026
@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

🤖 CI report

Bundle size — 🟢 -12 B (-0.0%)

Uncompressed size of every built .js bundle, compared against the base branch.

Total: 64.77 MiB · 🟢 -12 B (-0.0%)

No file changed by more than 1000 B.

Posted automatically by build-bundle-size-report · uncompressed bytes from dist-report

Eager graph — within budget

How much code each root ships on the eager path — downloaded and parsed before the surface is interactive. Measured from the esbuild output chunks (post-tree-shake, static imports only); lazy import() / React.lazy chunks are not counted.

Root Eager (shipped) Δ vs base Budget
entry (logged-out pages, app bootstrap)
src/index.tsx
1.22 MiB · 22 files no change ███░░░░░░░ 28.4% of 4.29 MiB
authenticated shell (every logged-in page)
src/scenes/AuthenticatedShell.tsx
8.15 MiB · 2,978 files no change █████████░ 88.1% of 9.25 MiB

🟢 node_modules/monaco-editor/ stays out of src/index.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/index.tsx
🟢 [object Object] stays out of src/index.tsx
🟢 [object Object] stays out of src/index.tsx
🟢 node_modules/monaco-editor/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx

Largest files eagerly shipped from src/index.tsx
Size File
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
24.6 KiB ../node_modules/.pnpm/buffer@6.0.3/node_modules/buffer/index.js
6.3 KiB ../node_modules/.pnpm/react@18.3.1/node_modules/react/cjs/react.production.min.js
4.5 KiB ../node_modules/.pnpm/@jspm+core@2.1.0/node_modules/@jspm/core/nodelibs/browser/process.js
3.9 KiB ../node_modules/.pnpm/scheduler@0.23.2/node_modules/scheduler/cjs/scheduler.production.min.js
1.4 KiB ../node_modules/.pnpm/base64-js@1.5.1/node_modules/base64-js/index.js
1.3 KiB src/RootErrorBoundary.tsx
912 B ../node_modules/.pnpm/ieee754@1.2.1/node_modules/ieee754/index.js
789 B src/scenes/ChunkLoadErrorBoundary.tsx
762 B src/index.tsx
Largest files eagerly shipped from src/scenes/AuthenticatedShell.tsx
Size File
281.1 KiB ../node_modules/.pnpm/posthog-js@1.401.0/node_modules/posthog-js/dist/rrweb.js
267.7 KiB ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js
235.5 KiB src/taxonomy/core-filter-definitions-by-group.json
222.7 KiB ../node_modules/.pnpm/posthog-js@1.401.0/node_modules/posthog-js/dist/module.js
164.0 KiB src/queries/validators.js
154.3 KiB ../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
106.1 KiB src/lib/api.ts
93.3 KiB ../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js
92.7 KiB ../packages/quill/packages/quill/dist/index.js

Posted automatically by check-eager-graph · sizes are eager output bytes (shipped, post-tree-shake) from the esbuild metafile · part of #32479

Dist folder size — 🟢 -35 B (-0.0%)

Total size of the built frontend/dist folder (all assets), compared against the base branch.

Total: 1307.94 MiB · 🟢 -35 B (-0.0%)

@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

🦔 Hogbox preview · ✅ ready

▶ Open the preview

🔑 Login test@posthog.com / 12345678 (demo data)
🧩 Running this PR's backend and frontend, on the PostHog :master base
🔗 Link stable across rebuilds — a re-push swaps the box underneath, the URL stays
🔒 Access tailnet only (PostHog VPN)
🛠️ Admin inspect & debug state in hogland
💤 Idle sleeps after ~30 min idle (snapshot to S3, zero node cost) and wakes on your next visit in ~30s, behind a brief "waking up" screen

commit b9e11a9 · box box-b8db77a8adec · ready in 778s (push → usable) · build log · rebuilds on every push, torn down on close

@pr-assigner-resolver-posthog
pr-assigner-resolver-posthog Bot requested a review from a team July 14, 2026 15:01
@pr-assigner-resolver-posthog

Copy link
Copy Markdown

👀 Auto-assigned reviewers

These soft owners were skipped because they only have minor changes here. Nothing blocks merge, so self-assign if you'd like a look:

  • @PostHog/team-self-driving (products/tracing/**)

Soft owners come from CODEOWNERS-soft and each product's product.yaml. Generated files and lockfiles are ignored when deciding ownership.

@greptile-apps

greptile-apps Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "fix(tracing): match the facet rail toggl..." | Re-trigger Greptile

@trunk-io

trunk-io Bot commented Jul 14, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

Generated-By: PostHog Code
Task-Id: 7eeea8df-accb-486b-a1e5-b37aea35a1d4
@posthog

posthog Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

👋 Visual changes detected for this PR.

Review and approve in PostHog Visual Review

If these changes are unexpected, they may be caused by a flaky test or a broken snapshot on master. Don't approve — rerun the job or wait for a fix.

Generated-By: PostHog Code
Task-Id: dd96a2e9-24f8-4f2f-8509-83bf54304cbd

Copy link
Copy Markdown
Contributor Author

CI is green. One note for reviewers: the Visual regression tests - chromium (12/16) shard initially failed on the Customer Analytics / Accounts › RowExpandedUsagePopulated play-test (waitForSelector timeout on [data-attr="account-expansion"]).

This is a pre-existing flake unrelated to this PR — this branch only touches products/tracing/frontend/TracingDisplayBar.tsx, and the customer_analytics / storybook files are byte-identical to master (which passed all 16 shards on the same tip). It has a history of dedicated flake-fix PRs (#69464, #69984, #70144). A re-run of the shard passed cleanly. The deploy preview check also hit a transient httpx.ReadTimeout while provisioning the preview box and went green on re-run.

🦉 via talyn.dev

@jonmcwest jonmcwest added the stamphog Request AI approval (no full review) label Jul 15, 2026
@jonmcwest
jonmcwest enabled auto-merge (squash) July 15, 2026 09:53

@stamphog stamphog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial, flag-gated style-only change with no behavior impact; author has strong familiarity with this code covering the cross-team gap.

  • Author wrote 100% of the modified lines and has 45 merged PRs in these paths (familiarity STRONG).
  • 👍 on the PR from greptile-apps[bot], hex-security-app[bot].
Gate mechanics and policy version
Gate Result
prerequisites all clear
deny-list no deny categories matched
size 8L, 1F substantive — within ceiling
tier T1-agent / T1a-trivial (8L, 1F, single-area, fix)
stamphog 2.0.0b3 .stamphog/policy.yml @ 11b7d38 · reviewed head 818ab6f

Generated-By: PostHog Code
Task-Id: 4ceae262-01fd-4adf-b5f8-695eeb68e564
Generated-By: PostHog Code
Task-Id: 1c85c7b7-38df-41a2-a47a-bcd1746a1a24
@jonmcwest
jonmcwest merged commit 71c32c4 into master Jul 15, 2026
193 of 203 checks passed
@jonmcwest
jonmcwest deleted the posthog-code/tracing-facet-rail-toggle-parity branch July 15, 2026 11:48

Copy link
Copy Markdown
Contributor Author

Update: green after merging master. The visual review initially flagged one changed snapshot — scenes-app-dashboards--edit--light — which is unrelated to this PR (this branch only touches products/tracing/frontend/TracingDisplayBar.tsx).

That snapshot is a known flaky one: its change history shows it flipping between changed and unchanged on plain master runs (no PR involved), with recurring structural diffs. I did not approve it (approving would have folded an unrelated baseline into this PR). Instead I re-rendered via a fresh run, and it came back clean — Visual Review now reports "No visual changes" and all checks pass.

🦉 via talyn.dev

@deployment-status-posthog

deployment-status-posthog Bot commented Jul 15, 2026

Copy link
Copy Markdown

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-07-15 12:19 UTC Run
prod-us ✅ Deployed 2026-07-15 12:43 UTC Run
prod-eu ✅ Deployed 2026-07-15 12:45 UTC Run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-agent-review Save $$$, skip auto agent reviews (Greptile) — use for trivial or chore PRs stamphog Request AI approval (no full review)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant