feat(cymbal): set posthog-php wire-order cutoff at 4.11.0 - #70879
Merged
Conversation
cat-ph
marked this pull request as ready for review
July 15, 2026 14:42
hpouillot
approved these changes
Jul 15, 2026
Contributor
|
Reviews (1): Last reviewed commit: "feat(cymbal): set posthog-php wire-order..." | Re-trigger Greptile |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fdbaefc439
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2 tasks
4.10.0 was claimed by an unrelated release before the flip merged.
cat-ph
changed the title
rnegron
pushed a commit
that referenced
this pull request
Jul 16, 2026
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Second SDK flip of the wire-order standardization (PostHog/sdk-specs#11): posthog-php ships canonical bottom-up frames in 4.11.0 (PostHog/posthog-php#200, latest release 4.10.0 + that PR's lone minor changeset). The normalization gate must stop reordering php payloads at that version.
The rust flip (#69837 + posthog-rs 0.19.1) validated the full mechanism in prod: post-flip events pass the gate untouched (stored order verified canonical on live traffic), no split wave, legacy matching healthy. PHP is next by the smallest-blast-radius ordering (~40k exception events/day, 52 teams) and is mechanically the cleanest crash-first SDK — no resolution reshaping, so legacy-order reconstruction is byte-exact even after the flip.
Changes
posthog-phpgetscanonical_since: Some(4.11.0)in the normalization table; everything below (or unparseable, e.g.dev-main) keeps normalizing.dev-main/ missing versions still normalize; 4.11.x, 4.12.0, 5.0.0 pass through; legacy-order reconstruction ignores the cutoff (continuity for pre-flip-keyed issues).Merge sequencing — do not merge out of order
Watch on the
et-wire-order-launchdashboard as with rs.How did you test this code?
Automated only: new
php_cutoff_gates_normalization_by_versionunit test; fullcargo test -p cymbal306 passed, 0 failed (DB-backed tests against local Postgres + Kafka); clippy-D warningsand fmt clean. The change is a mechanical clone of the reviewed rs cutoff (#69837).Automatic notifications
Docs update
Rollout process documented in the sdk-specs change.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Claude Code authored this under my direction, step 2 of the per-SDK flip rollout, following the sequencing contract established in #69837. Target version derived from posthog-php's latest release plus #200's pending changeset (verified no other changesets are queued).