chore: record error-tracking autocapture receiver in setup baseline - #70903
Closed
rnegron wants to merge 1 commit into
Closed
chore: record error-tracking autocapture receiver in setup baseline#70903rnegron wants to merge 1 commit into
rnegron wants to merge 1 commit into
Conversation
rnegron
marked this pull request as ready for review
July 14, 2026 21:11
Contributor
|
Reviews (1): Last reviewed commit: "chore: record error-tracking autocapture..." | Re-trigger Greptile |
Contributor
🤖 CI report
|
Member
Author
|
Replaced by #70869 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Master has been red on Backend CI since feat(error-tracking): move autocapture opt-in to settings (phase 1) merged. That PR added a new
post_savereceiver (mirror_autocapture_opt_in_to_settings) that connects atdjango.setup(), but didn't record it in the committed startup-receiver baseline.test_setup_receivers_match_baselinepins the exact set of first-party receivers wired at setup, so the unrecorded one fails the guard on every master run.Changes
posthog/test/setup_receivers_baseline.txt, in sorted position.The receiver's wiring is already correct (import-light
signals.pyimported fromErrorTrackingConfig.ready()with# noqa: F401), andtest_no_new_heavy_imports_at_setupstill passes, so recording it is the right fix rather than restructuring.How did you test this code?
django.setup()receiver capture in a clean subprocess and confirmed the updated 217-line baseline is a zero-diff exact match for the live receiver set.DEBUG=1, which leaks a settings warning onto the subprocess stdout and would false-fail the assertion. CI has no such artifact.🤖 Agent context
Autonomy: Human-driven (agent-assisted)
/django-startup-timeskill to confirm the guard's intent and that "record in baseline" (not defer/restructure) was the correct fix here.ready()-wired, and validated the baseline diff before committing.