feat(web-analytics): roll no-join fast paths to all us cloud teams - #70940
Merged
Conversation
lricoy
marked this pull request as ready for review
July 15, 2026 13:58
lricoy
enabled auto-merge (squash)
July 15, 2026 13:58
Contributor
|
Reviews (1): Last reviewed commit: "feat(web-analytics): roll no-join fast p..." | Re-trigger Greptile |
There was a problem hiding this comment.
One-line rollout-percentage config bump backed by production evidence, with an existing kill switch and boundary tests; author has STRONG familiarity with this exact file.
- Author wrote 100% of the modified lines and has 12 merged PRs in these paths (familiarity STRONG).
- 👍 on the PR from chatgpt-codex-connector[bot], greptile-apps[bot], hex-security-app[bot].
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 2L, 1F substantive — within ceiling |
| tier | ✓ | T1-agent / T1a-trivial (2L, 1F, single-area, feat) |
| stamphog 2.0.0b3 | .stamphog/policy.yml @ b821150 · reviewed head d624f52 |
Contributor
🤖 CI reportℹ️ ClickHouse migration SQL — 1 migration(s)ClickHouse migration SQL per cloud environment
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The no-join fast paths (#70746) rolled to 50% of US Cloud teams via deterministic team bucketing (#70906). Production evidence after 14 hours at 50%:
Coverage math: ~86% of user-facing web analytics queries reaching ClickHouse are unfiltered and therefore eligible; at 50% team bucketing roughly half of that population is served today, so this PR approximately doubles fast-path coverage to all eligible US traffic.
(Eligible population = user-facing, unfiltered, no test-account filtering - the class the fast path serves. The post p99 tail is bounded-memory queue contention on the dogfooding team, not query cost.)
Changes
One line: the US Cloud default for
WEB_ANALYTICS_NO_JOIN_ROLLOUT_PERCENTgoes 50 → 100. Every US team's unfiltered overview and paths queries take the fast path on deploy. EU stays at 0 (pending its ClickHouse 26.6 upgrade convergence + separate verification), self-hosted and tests unaffected. The env var remains a two-way override and the kill switch.How did you test this code?
TestWebOverviewNoJoinRolloutPercent(boundary-exact tests) from feat(web-analytics): percentage-of-teams rollout for no-join fast paths #70906.stats_table_no_join_*/web_overview_no_join_querytags (feat(web-analytics): tag no-join overview executions with their own query type #70934) andweb_analytics_no_join_served_total.Automatic notifications
Docs update
No user-facing behavior change (results parity verified; latency improves).
🤖 Agent context
Autonomy: Human-driven (agent-assisted)