Skip to content

fix(notebooks): regenerate stale kea typegen for SQL V2 logic - #71047

Merged
webjunkie merged 1 commit into
masterfrom
posthog-code/fix-sqlv2-logic-typegen
Jul 15, 2026
Merged

fix(notebooks): regenerate stale kea typegen for SQL V2 logic#71047
webjunkie merged 1 commit into
masterfrom
posthog-code/fix-sqlv2-logic-typegen

Conversation

@webjunkie

Copy link
Copy Markdown
Contributor

Problem

Master's Frontend CI is red: the "Check if schema.json and validators.js are up to date" step fails because the inline kea-typegen block in notebookNodeSQLV2Logic.ts is stale. A change added isInterrupting state plus interruptRun / setIsInterrupting actions to the logic, but the committed generated types weren't refreshed, so typegen produces a diff in CI.

Changes

Regenerate the inline typegen block for notebookNodeSQLV2Logic: add isInterrupting to the values interface and interruptRun / setIsInterrupting to the actions interface. Matches exactly the output the CI check computes.

How did you test this code?

node_modules isn't available in this environment, so I couldn't run typegen locally. Instead I applied the precise diff that the failing CI step printed as its expected output, so the git diff --exit-code check will now pass. No behavior change — this only updates generated type declarations.

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

🤖 Agent context

Autonomy: Fully autonomous

Triggered by a master-is-red alert. Diagnosed the failing Frontend CI run (Frontend typechecking → schema/validators check), traced it to a stale inline typegen block under frontend/src/scenes/notebooks (an inlinePaths directory in .kearc), and applied the exact regeneration the CI step expects.


Created with PostHog from a Slack thread

The notebookNodeSQLV2Logic inline typegen block was missing the
isInterrupting value and the interruptRun / setIsInterrupting actions,
breaking the "schema.json and validators.js are up to date" check on
master.

Generated-By: PostHog Code
Task-Id: 39aa7001-6d83-485d-bb73-96359abffdbf
@github-actions

Copy link
Copy Markdown
Contributor

Hey @webjunkie! 👋

It looks like your git author email on this PR isn't your @posthog.com address (julian.bez@gmail.com). Since you're on the PostHog team, it's worth pointing your local git author email at your @posthog.com address. Why it matters:

  • Consistent work identity in git history — internal tooling that attributes commits to team members keys off your @posthog.com address.
  • Keeps team contributions easy to tell apart from external community ones when scanning history.

You can fix it for this repo with:

git config user.email "you@posthog.com"

Or set it globally with git config --global user.email "you@posthog.com". No need to redo this PR — just a nudge for next time. 🙂

@webjunkie
webjunkie marked this pull request as ready for review July 15, 2026 12:27
Copilot AI review requested due to automatic review settings July 15, 2026 12:27
@webjunkie
webjunkie enabled auto-merge (squash) July 15, 2026 12:27
@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

🦔 Hogbox preview · ✅ ready

▶ Open the preview

🔑 Login test@posthog.com / 12345678 (demo data)
🧩 Running this PR's backend and frontend, on the PostHog :master base
🔗 Link stable across rebuilds — a re-push swaps the box underneath, the URL stays
🔒 Access tailnet only (PostHog VPN)
🛠️ Admin inspect & debug state in hogland
💤 Idle sleeps after ~30 min idle (snapshot to S3, zero node cost) and wakes on your next visit in ~30s, behind a brief "waking up" screen

commit 880a81f · box box-7b3bd96b7334 · ready in 752s (push → usable) · build log · rebuilds on every push, torn down on close

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a Frontend CI failure caused by a stale inline kea-typegen block in the notebooks SQL V2 kea logic. It updates the generated TypeScript interfaces to reflect newly added interrupt state/actions so the “schema.json and validators.js up to date” check no longer produces a diff.

Changes:

  • Regenerated the inline kea-typegen interfaces for notebookNodeSQLV2Logic.
  • Added isInterrupting to notebookNodeSQLV2LogicValues.
  • Added interruptRun and setIsInterrupting to notebookNodeSQLV2LogicActions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

🤖 CI report

Bundle size — no change

Uncompressed size of every built .js bundle, compared against the base branch.

Total: 64.77 MiB · no change

No file changed by more than 1000 B.

Posted automatically by build-bundle-size-report · uncompressed bytes from dist-report

Eager graph — within budget

How much code each root ships on the eager path — downloaded and parsed before the surface is interactive. Measured from the esbuild output chunks (post-tree-shake, static imports only); lazy import() / React.lazy chunks are not counted.

Root Eager (shipped) Δ vs base Budget
entry (logged-out pages, app bootstrap)
src/index.tsx
1.22 MiB · 22 files no change ███░░░░░░░ 28.4% of 4.29 MiB
authenticated shell (every logged-in page)
src/scenes/AuthenticatedShell.tsx
8.15 MiB · 2,978 files no change █████████░ 88.1% of 9.25 MiB

🟢 node_modules/monaco-editor/ stays out of src/index.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/index.tsx
🟢 [object Object] stays out of src/index.tsx
🟢 [object Object] stays out of src/index.tsx
🟢 node_modules/monaco-editor/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx

Largest files eagerly shipped from src/index.tsx
Size File
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
24.6 KiB ../node_modules/.pnpm/buffer@6.0.3/node_modules/buffer/index.js
6.3 KiB ../node_modules/.pnpm/react@18.3.1/node_modules/react/cjs/react.production.min.js
4.5 KiB ../node_modules/.pnpm/@jspm+core@2.1.0/node_modules/@jspm/core/nodelibs/browser/process.js
3.9 KiB ../node_modules/.pnpm/scheduler@0.23.2/node_modules/scheduler/cjs/scheduler.production.min.js
1.4 KiB ../node_modules/.pnpm/base64-js@1.5.1/node_modules/base64-js/index.js
1.3 KiB src/RootErrorBoundary.tsx
912 B ../node_modules/.pnpm/ieee754@1.2.1/node_modules/ieee754/index.js
789 B src/scenes/ChunkLoadErrorBoundary.tsx
762 B src/index.tsx
Largest files eagerly shipped from src/scenes/AuthenticatedShell.tsx
Size File
281.1 KiB ../node_modules/.pnpm/posthog-js@1.401.0/node_modules/posthog-js/dist/rrweb.js
267.7 KiB ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js
235.5 KiB src/taxonomy/core-filter-definitions-by-group.json
222.7 KiB ../node_modules/.pnpm/posthog-js@1.401.0/node_modules/posthog-js/dist/module.js
164.0 KiB src/queries/validators.js
154.3 KiB ../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
106.1 KiB src/lib/api.ts
93.3 KiB ../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js
92.7 KiB ../packages/quill/packages/quill/dist/index.js

Posted automatically by check-eager-graph · sizes are eager output bytes (shipped, post-tree-shake) from the esbuild metafile · part of #32479

Dist folder size — 🔺 +358 B (+0.0%)

Total size of the built frontend/dist folder (all assets), compared against the base branch.

Total: 1308.09 MiB · 🔺 +358 B (+0.0%)

Playwright — all passed

All tests passed.

View test results →

@trunk-io

trunk-io Bot commented Jul 15, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@webjunkie
webjunkie disabled auto-merge July 15, 2026 12:42
@webjunkie
webjunkie merged commit a77dc45 into master Jul 15, 2026
260 of 272 checks passed
@webjunkie
webjunkie deleted the posthog-code/fix-sqlv2-logic-typegen branch July 15, 2026 12:43
@posthog

posthog Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

👋 Visual changes detected for this PR.

Review and approve in PostHog Visual Review

If these changes are unexpected, they may be caused by a flaky test or a broken snapshot on master. Don't approve — rerun the job or wait for a fix.

@deployment-status-posthog

deployment-status-posthog Bot commented Jul 15, 2026

Copy link
Copy Markdown

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-07-15 13:19 UTC Run
prod-us ✅ Deployed 2026-07-15 13:46 UTC Run
prod-eu ✅ Deployed 2026-07-15 13:46 UTC Run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants