fix(notebooks): regenerate stale kea typegen for SQL V2 logic - #71047
Conversation
The notebookNodeSQLV2Logic inline typegen block was missing the isInterrupting value and the interruptRun / setIsInterrupting actions, breaking the "schema.json and validators.js are up to date" check on master. Generated-By: PostHog Code Task-Id: 39aa7001-6d83-485d-bb73-96359abffdbf
|
Hey @webjunkie! 👋 It looks like your git author email on this PR isn't your
You can fix it for this repo with: git config user.email "you@posthog.com"Or set it globally with |
🦔 Hogbox preview · ✅ ready▶ Open the preview
commit |
There was a problem hiding this comment.
Pull request overview
This PR fixes a Frontend CI failure caused by a stale inline kea-typegen block in the notebooks SQL V2 kea logic. It updates the generated TypeScript interfaces to reflect newly added interrupt state/actions so the “schema.json and validators.js up to date” check no longer produces a diff.
Changes:
- Regenerated the inline
kea-typegeninterfaces fornotebookNodeSQLV2Logic. - Added
isInterruptingtonotebookNodeSQLV2LogicValues. - Added
interruptRunandsetIsInterruptingtonotebookNodeSQLV2LogicActions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
🤖 CI report✅ Bundle size — no changeUncompressed size of every built Total: 64.77 MiB · no change No file changed by more than 1000 B. Posted automatically by build-bundle-size-report · uncompressed bytes from dist-report ✅ Eager graph — within budgetHow much code each root ships on the eager path — downloaded and parsed before the surface is interactive. Measured from the esbuild output chunks (post-tree-shake, static imports only); lazy
🟢 Largest files eagerly shipped from
|
| Size | File |
|---|---|
| 126.8 KiB | ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js |
| 24.6 KiB | ../node_modules/.pnpm/buffer@6.0.3/node_modules/buffer/index.js |
| 6.3 KiB | ../node_modules/.pnpm/react@18.3.1/node_modules/react/cjs/react.production.min.js |
| 4.5 KiB | ../node_modules/.pnpm/@jspm+core@2.1.0/node_modules/@jspm/core/nodelibs/browser/process.js |
| 3.9 KiB | ../node_modules/.pnpm/scheduler@0.23.2/node_modules/scheduler/cjs/scheduler.production.min.js |
| 1.4 KiB | ../node_modules/.pnpm/base64-js@1.5.1/node_modules/base64-js/index.js |
| 1.3 KiB | src/RootErrorBoundary.tsx |
| 912 B | ../node_modules/.pnpm/ieee754@1.2.1/node_modules/ieee754/index.js |
| 789 B | src/scenes/ChunkLoadErrorBoundary.tsx |
| 762 B | src/index.tsx |
Largest files eagerly shipped from src/scenes/AuthenticatedShell.tsx
| Size | File |
|---|---|
| 281.1 KiB | ../node_modules/.pnpm/posthog-js@1.401.0/node_modules/posthog-js/dist/rrweb.js |
| 267.7 KiB | ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js |
| 235.5 KiB | src/taxonomy/core-filter-definitions-by-group.json |
| 222.7 KiB | ../node_modules/.pnpm/posthog-js@1.401.0/node_modules/posthog-js/dist/module.js |
| 164.0 KiB | src/queries/validators.js |
| 154.3 KiB | ../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js |
| 126.8 KiB | ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js |
| 106.1 KiB | src/lib/api.ts |
| 93.3 KiB | ../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js |
| 92.7 KiB | ../packages/quill/packages/quill/dist/index.js |
Posted automatically by check-eager-graph · sizes are eager output bytes (shipped, post-tree-shake) from the esbuild metafile · part of #32479
✅ Dist folder size — 🔺 +358 B (+0.0%)
Total size of the built frontend/dist folder (all assets), compared against the base branch.
Total: 1308.09 MiB · 🔺 +358 B (+0.0%)
|
👋 Visual changes detected for this PR. Review and approve in PostHog Visual Review If these changes are unexpected, they may be caused by a flaky test or a broken snapshot on master. Don't approve — rerun the job or wait for a fix. |
Problem
Master's Frontend CI is red: the "Check if schema.json and validators.js are up to date" step fails because the inline kea-typegen block in
notebookNodeSQLV2Logic.tsis stale. A change addedisInterruptingstate plusinterruptRun/setIsInterruptingactions to the logic, but the committed generated types weren't refreshed, sotypegenproduces a diff in CI.Changes
Regenerate the inline typegen block for
notebookNodeSQLV2Logic: addisInterruptingto the values interface andinterruptRun/setIsInterruptingto the actions interface. Matches exactly the output the CI check computes.How did you test this code?
node_modules isn't available in this environment, so I couldn't run
typegenlocally. Instead I applied the precise diff that the failing CI step printed as its expected output, so thegit diff --exit-codecheck will now pass. No behavior change — this only updates generated type declarations.Automatic notifications
🤖 Agent context
Autonomy: Fully autonomous
Triggered by a master-is-red alert. Diagnosed the failing Frontend CI run (Frontend typechecking → schema/validators check), traced it to a stale inline typegen block under
frontend/src/scenes/notebooks(aninlinePathsdirectory in.kearc), and applied the exact regeneration the CI step expects.Created with PostHog from a Slack thread