chore(dashboards): remove dashboard quick filters experiment - #71058
Conversation
🤖 CI report✅ Bundle size — 🟢 -8.1 KiB (-0.0%)Uncompressed size of every built Total: 64.79 MiB · 🟢 -8.1 KiB (-0.0%)
Posted automatically by build-bundle-size-report · uncompressed bytes from dist-report ✅ Eager graph — within budgetHow much code each root ships on the eager path — downloaded and parsed before the surface is interactive. Measured from the esbuild output chunks (post-tree-shake, static imports only); lazy
🟢 Largest files eagerly shipped from
|
| Size | File |
|---|---|
| 126.8 KiB | ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js |
| 24.6 KiB | ../node_modules/.pnpm/buffer@6.0.3/node_modules/buffer/index.js |
| 6.3 KiB | ../node_modules/.pnpm/react@18.3.1/node_modules/react/cjs/react.production.min.js |
| 4.5 KiB | ../node_modules/.pnpm/@jspm+core@2.1.0/node_modules/@jspm/core/nodelibs/browser/process.js |
| 3.9 KiB | ../node_modules/.pnpm/scheduler@0.23.2/node_modules/scheduler/cjs/scheduler.production.min.js |
| 1.4 KiB | ../node_modules/.pnpm/base64-js@1.5.1/node_modules/base64-js/index.js |
| 1.3 KiB | src/RootErrorBoundary.tsx |
| 912 B | ../node_modules/.pnpm/ieee754@1.2.1/node_modules/ieee754/index.js |
| 789 B | src/scenes/ChunkLoadErrorBoundary.tsx |
| 762 B | src/index.tsx |
Largest files eagerly shipped from src/scenes/AuthenticatedShell.tsx
| Size | File |
|---|---|
| 281.1 KiB | ../node_modules/.pnpm/posthog-js@1.401.0/node_modules/posthog-js/dist/rrweb.js |
| 267.7 KiB | ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js |
| 235.5 KiB | src/taxonomy/core-filter-definitions-by-group.json |
| 222.7 KiB | ../node_modules/.pnpm/posthog-js@1.401.0/node_modules/posthog-js/dist/module.js |
| 164.0 KiB | src/queries/validators.js |
| 154.3 KiB | ../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js |
| 126.8 KiB | ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js |
| 106.1 KiB | src/lib/api.ts |
| 93.3 KiB | ../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js |
| 92.7 KiB | ../packages/quill/packages/quill/dist/index.js |
Posted automatically by check-eager-graph · sizes are eager output bytes (shipped, post-tree-shake) from the esbuild metafile · part of #32479
✅ Dist folder size — 🟢 -102.7 KiB (-0.0%)
Total size of the built frontend/dist folder (all assets), compared against the base branch.
Total: 1308.62 MiB · 🟢 -102.7 KiB (-0.0%)
⚠️ Playwright — 1 failed
🎭 Playwright report · View test results →
❌ 1 failed test:
- level facet passes severityLevels to API (chromium)
These issues are not necessarily caused by your changes.
Annoyed by this section? Help fix flakies and failures and it will go green!
🦔 Hogbox preview · ❌ build failedThe preview didn't come up for commit |
|
|
Re Greptile's P1 "DataOps Filter Bar Disappears": false positive. Comment posted by PostHog Code on behalf of Thomas. |
The experiment failed, so the control experience (edit bar) stays. Removes the flag, the dashboard-scene quick filter UI and logics, and the quick filter wiring in dashboardLogic. The shared QuickFilters library and backend API remain in use by other surfaces (error tracking, dashboard widgets). Generated-By: PostHog Code Task-Id: 7c2776aa-ecf7-4d4c-8f47-7928c7a0daa1
b735559 to
f26b172
Compare
2 participants
TL;DR
The dashboard quick filters A/B test lost, so the code behind it is being deleted. Dashboards keep the regular filter edit bar everyone in the control group already sees. Nothing changes for users.
Problem
The
dashboard-quick-filters-experimentfeature flag gated a quick-filters bar on the dashboard scene. The experiment failed, so the test-variant code should be removed and the control experience (the standard edit bar) kept.Changes
DASHBOARD_QUICK_FILTERS_EXPERIMENTflag constantDashboardQuickFiltersButton,dashboardQuickFiltersLogic,dashboardQuickFiltersSelectionLogic,dashboardFiltersLogic(advanced-options toggle), and the debounce testDashboardFilters.tsxto always renderDashboardEditBarand strip quick-filter rows/advanced optionsdashboardLogic(URL restore deferral, commit-debounce refresh, filter merging selectors,dashboardFiltersEnabled)The shared
lib/components/QuickFilterslibrary,QuickFilterContext, and the backendQuickFiltermodel/API are untouched — they're used by error tracking and dashboard widgets. The now-unusedDashboard.quick_filter_idsbackend field is left in place; dropping the column safely is a separate staged migration if wanted.Why
The experiment failed, so the losing variant's code is dead weight and the flag can be cleaned up.
How did you test this code?
No manual testing (headless environment without node_modules). Ran oxfmt and oxlint on the changed files; verified via repo-wide search that no references to the removed flag, components, selectors, or actions remain. Existing dashboard tests and CI typecheck cover the touched paths. Deleted
dashboardQuickFiltersDebounce.test.tssince it only tested removed behavior.Automatic notifications
Docs update
None needed — experiment was never documented.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Authored with PostHog Code (Claude Code). Scoped the removal by tracing what the
dashboard-quick-filters-experimentflag actually gated (dashboardFiltersEnabledselector); deliberately kept the shared QuickFilters library and backend model/API because error tracking and dashboard widgets consume them, and left thequick_filter_idsdashboard field for a separate column-drop migration.Created with PostHog Code