chore(clickhouse): bump hclexp pin to sha-5756e98 - #71069
Merged
Conversation
orian
marked this pull request as ready for review
July 15, 2026 13:39
rorylshanks
approved these changes
Jul 15, 2026
Contributor
|
Reviews (1): Last reviewed commit: "Merge remote-tracking branch 'origin/mas..." | Re-trigger Greptile |
|
Contributor
🤖 CI report |
orian
enabled auto-merge (squash)
July 15, 2026 14:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The declarative ClickHouse schema tooling (
hclexp) is pinned tosha-2f80e66inposthog/clickhouse/hcl/bin/image.txt, the single place both the offlinecheck.shgate and the multinode convergence gate resolve. That build predates several chschema releases the HCL recreate work depends on:diff -format jsonper-objectobjects/summarywith attribute-level field changes,drift -format json, per-rolerolesinplan, and native-exclude(incl.object_types) on all three.CREATE OR REPLACEreconcile and precise named-collection redaction.hclexp locatewith-duplicates, the once-only-declaration audit that becomes the new composition's CI guard.This is the first PR of the HCL recreate plan and unblocks the later phases (per-object comparison for decomposition,
locate -duplicatesas a check). It should land before anything else.Changes
Bump the pin from
sha-2f80e66tosha-5756e98(hclexp v0.1.1-11tov0.1.1-16). One line, no other files.The goldens and generated SQL are unchanged: the new build regenerates
golden/andsql/byte-for-byte identical to what is committed. #139 is documented as a no-op for introspection and DDL generation, and #143's named-collection redaction touches no object in this composition, so nothing shifts.How did you test this code?
All runs use the pinned Docker image (I forced the container path so a stray local
hclexponPATHcould not shadow it):golden/+sql/withsha-2f80e66first.git diffwas empty, confirming the harness reproduces the committed artifacts exactly.sha-5756e98.golden/andsql/diff is empty, so the pin change alters no output.check.shgreen under the new pin: every role validates, every(env, role)stack diffs clean against its golden, andsql/freshness passes.hogli ci:preflighton the branch diff: 0 failures, nothing maps to a known CI failure class.Automatic notifications
Docs update
No user-facing behavior changes.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
I (Claude) executed Task 0.1 Step 2 of
docs/plans/2026-07-14-hcl-recreate.mdunder Pawel's direction. Followedsuperpowers:subagent-driven-developmentfor the session, though for a one-line pin bump the substantive work was verification, not delegation, so I did it directly.Key checks along the way: established a clean old-pin baseline before touching anything so any golden shift would be attributable purely to the bump; forced the Docker image path because a dev-build
hclexpwas onPATHand would otherwise have generated the goldens instead of the pinned build. The plan flagged #143 as a possible source of golden drift that "must be reviewed, not rubber-stamped" — verified it produces no shift here rather than assuming so.