Skip to content

chore(clickhouse): bump hclexp pin to sha-5756e98 - #71069

Merged
orian merged 2 commits into
masterfrom
pawel/chore/hcl-bump-hclexp-pin
Jul 15, 2026
Merged

chore(clickhouse): bump hclexp pin to sha-5756e98#71069
orian merged 2 commits into
masterfrom
pawel/chore/hcl-bump-hclexp-pin

Conversation

@orian

@orian orian commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Problem

The declarative ClickHouse schema tooling (hclexp) is pinned to sha-2f80e66 in posthog/clickhouse/hcl/bin/image.txt, the single place both the offline check.sh gate and the multinode convergence gate resolve. That build predates several chschema releases the HCL recreate work depends on:

This is the first PR of the HCL recreate plan and unblocks the later phases (per-object comparison for decomposition, locate -duplicates as a check). It should land before anything else.

Changes

Bump the pin from sha-2f80e66 to sha-5756e98 (hclexp v0.1.1-11 to v0.1.1-16). One line, no other files.

The goldens and generated SQL are unchanged: the new build regenerates golden/ and sql/ byte-for-byte identical to what is committed. #139 is documented as a no-op for introspection and DDL generation, and #143's named-collection redaction touches no object in this composition, so nothing shifts.

How did you test this code?

All runs use the pinned Docker image (I forced the container path so a stray local hclexp on PATH could not shadow it):

  1. Baseline at the old pin. Regenerated golden/ + sql/ with sha-2f80e66 first. git diff was empty, confirming the harness reproduces the committed artifacts exactly.
  2. After the bump. Regenerated with sha-5756e98. golden/ and sql/ diff is empty, so the pin change alters no output.
  3. check.sh green under the new pin: every role validates, every (env, role) stack diffs clean against its golden, and sql/ freshness passes.
  4. hogli ci:preflight on the branch diff: 0 failures, nothing maps to a known CI failure class.

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Docs update

No user-facing behavior changes.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

I (Claude) executed Task 0.1 Step 2 of docs/plans/2026-07-14-hcl-recreate.md under Pawel's direction. Followed superpowers:subagent-driven-development for the session, though for a one-line pin bump the substantive work was verification, not delegation, so I did it directly.

Key checks along the way: established a clean old-pin baseline before touching anything so any golden shift would be attributable purely to the bump; forced the Docker image path because a dev-build hclexp was on PATH and would otherwise have generated the goldens instead of the pinned build. The plan flagged #143 as a possible source of golden drift that "must be reviewed, not rubber-stamped" — verified it produces no shift here rather than assuming so.

@orian orian added the skip-agent-review Save $$$, skip auto agent reviews (Greptile) — use for trivial or chore PRs label Jul 15, 2026
@orian orian self-assigned this Jul 15, 2026
@orian
orian marked this pull request as ready for review July 15, 2026 13:39
@pr-assigner-resolver-posthog
pr-assigner-resolver-posthog Bot requested a review from a team July 15, 2026 13:39
@greptile-apps

greptile-apps Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "Merge remote-tracking branch 'origin/mas..." | Re-trigger Greptile

Comment thread posthog/clickhouse/hcl/bin/image.txt
@trunk-io

trunk-io Bot commented Jul 15, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
test_insert_into_stage_activity_reports_records_total_for_events_model[data_interval_end0-model0-day] The number of records counted does not match the expected total, indicating a discrepancy in the data. Logs ↗︎

View Full Report ↗︎Docs

@github-actions

Copy link
Copy Markdown
Contributor

🤖 CI report

Playwright — all passed

All tests passed.

View test results →

@orian
orian enabled auto-merge (squash) July 15, 2026 14:08
@orian
orian merged commit 48bee72 into master Jul 15, 2026
429 of 474 checks passed
@orian
orian deleted the pawel/chore/hcl-bump-hclexp-pin branch July 15, 2026 14:11
@deployment-status-posthog

deployment-status-posthog Bot commented Jul 15, 2026

Copy link
Copy Markdown

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-07-15 14:33 UTC Run
prod-us ✅ Deployed 2026-07-15 15:01 UTC Run
prod-eu ✅ Deployed 2026-07-15 15:01 UTC Run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-agent-review Save $$$, skip auto agent reviews (Greptile) — use for trivial or chore PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants