Skip to content

feat(hogli): support 200 GiB devboxes - #71107

Merged
rnegron merged 1 commit into
masterfrom
worktree-hogli-devbox-disk-200
Jul 15, 2026
Merged

feat(hogli): support 200 GiB devboxes#71107
rnegron merged 1 commit into
masterfrom
worktree-hogli-devbox-disk-200

Conversation

@rnegron

@rnegron rnegron commented Jul 15, 2026

Copy link
Copy Markdown
Member

Problem

  • hogli devbox:start --disk only offered 60 / 80 / 100 GiB. The posthog-linux Coder template has since moved on: 100 GiB is the golden-AMI floor (smaller volumes fail at launch with InvalidBlockDeviceMapping), and it now exposes a 200 GiB option. So the CLI advertised two sizes that fail at launch and couldn't create the larger boxes the template supports.

Changes

  • --disk choices are now 100 / 200, matching the template's disk_size options.
  • Added a comment tying the choice list back to the template so the two stay in sync.

How did you test this code?

  • Added test_devbox_start_forwards_larger_disk_size: asserts --disk 200 is accepted and reaches create_workspace as disk_size="200". No existing test covered a non-default disk, so this guards the choice list drifting from the template's valid options.
  • ruff check / ruff format clean, hogli ci:preflight --strict passes.

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Docs update

  • None. The infra-side disk options live in posthog-cloud-infra, not this repo.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

  • Authored by Claude (Opus 4.8) at Raúl's direction. Skill invoked: /writing-tests.
  • Source of truth for valid sizes is the posthog-linux template's disk_size parameter (100/200 GiB). I dropped the below-floor 60/80 options rather than only adding 200, since those now fail at launch.

@rnegron rnegron self-assigned this Jul 15, 2026
@rnegron rnegron added the skip-agent-review Save $$$, skip auto agent reviews (Greptile) — use for trivial or chore PRs label Jul 15, 2026
@rnegron
rnegron marked this pull request as ready for review July 15, 2026 15:01
@rnegron rnegron added the stamphog Request AI approval (no full review) label Jul 15, 2026
@pr-assigner-resolver-posthog
pr-assigner-resolver-posthog Bot requested a review from a team July 15, 2026 15:01
@greptile-apps

greptile-apps Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "Merge branch 'master' into worktree-hogl..." | Re-trigger Greptile

@rnegron
rnegron force-pushed the worktree-hogli-devbox-disk-200 branch from 9d4e58f to 8dab086 Compare July 15, 2026 15:03
stamphog[bot]
stamphog Bot previously approved these changes Jul 15, 2026

@stamphog stamphog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small, contained change to the hogli devbox CLI disk-size choices with a new test; not risky territory, author is on the owning team with strong familiarity, no unresolved concerns.

  • Author wrote 100% of the modified lines and has 34 merged PRs in these paths (familiarity STRONG).
  • 👍 on the PR from greptile-apps[bot], hex-security-app[bot].
Gate mechanics and policy version
Gate Result
prerequisites all clear
deny-list no deny categories matched
size 4L, 1F substantive, 21L/2F incl. docs/generated/snapshots — within ceiling
tier T1-agent / T1b-small (21L, 2F, single-area, feat)
stamphog 2.0.0b3 .stamphog/policy.yml @ 48f809c · reviewed head 9d4e58f

@rnegron
rnegron enabled auto-merge (squash) July 15, 2026 15:04
@stamphog
stamphog Bot dismissed their stale review July 15, 2026 15:05

New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.

@stamphog stamphog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial internal CLI tooling change (disk size choices) with a new test, matches description, author owns the code with strong familiarity, no risky territory.

  • Author wrote 100% of the modified lines and has 34 merged PRs in these paths (familiarity STRONG).
  • 👍 on the PR from greptile-apps[bot], hex-security-app[bot].
Gate mechanics and policy version
Gate Result
prerequisites all clear
deny-list no deny categories matched
size 2L, 1F substantive, 19L/2F incl. docs/generated/snapshots — within ceiling
tier T1-agent / T1a-trivial (19L, 2F, single-area, feat)
stamphog 2.0.0b3 .stamphog/policy.yml @ 061e90d · reviewed head 8dab086

@rnegron
rnegron merged commit 2e543ac into master Jul 15, 2026
183 checks passed
@rnegron
rnegron deleted the worktree-hogli-devbox-disk-200 branch July 15, 2026 15:19
@trunk-io

trunk-io Bot commented Jul 15, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@deployment-status-posthog

deployment-status-posthog Bot commented Jul 15, 2026

Copy link
Copy Markdown

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-07-15 16:00 UTC Run
prod-us ✅ Deployed 2026-07-15 16:19 UTC Run
prod-eu ✅ Deployed 2026-07-15 16:21 UTC Run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-agent-review Save $$$, skip auto agent reviews (Greptile) — use for trivial or chore PRs stamphog Request AI approval (no full review)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants