feat(notebooks): show kernel UI when revamped-py-notebooks is enabled - #71424
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
🤖 CI report
|
| Root | Eager (shipped) | Δ vs base | Budget |
|---|---|---|---|
entry (logged-out pages, app bootstrap)src/index.tsx |
1.22 MiB · 22 files | no change | ███░░░░░░░ 28.4% of 4.29 MiB |
authenticated shell (every logged-in page)src/scenes/AuthenticatedShell.tsx |
8.13 MiB · 2,978 files | 🔺 +87 B (+0.0%) | █████████░ 87.9% of 9.25 MiB |
🟢 node_modules/monaco-editor/ stays out of src/index.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/index.tsx
🟢 [object Object] stays out of src/index.tsx
🟢 [object Object] stays out of src/index.tsx
🟢 node_modules/monaco-editor/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
Largest files eagerly shipped from src/index.tsx
| Size | File |
|---|---|
| 126.8 KiB | ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js |
| 24.6 KiB | ../node_modules/.pnpm/buffer@6.0.3/node_modules/buffer/index.js |
| 6.3 KiB | ../node_modules/.pnpm/react@18.3.1/node_modules/react/cjs/react.production.min.js |
| 4.5 KiB | ../node_modules/.pnpm/@jspm+core@2.1.0/node_modules/@jspm/core/nodelibs/browser/process.js |
| 3.9 KiB | ../node_modules/.pnpm/scheduler@0.23.2/node_modules/scheduler/cjs/scheduler.production.min.js |
| 1.4 KiB | ../node_modules/.pnpm/base64-js@1.5.1/node_modules/base64-js/index.js |
| 1.3 KiB | src/RootErrorBoundary.tsx |
| 912 B | ../node_modules/.pnpm/ieee754@1.2.1/node_modules/ieee754/index.js |
| 789 B | src/scenes/ChunkLoadErrorBoundary.tsx |
| 762 B | src/index.tsx |
Largest files eagerly shipped from src/scenes/AuthenticatedShell.tsx
| Size | File |
|---|---|
| 281.3 KiB | ../node_modules/.pnpm/posthog-js@1.402.3/node_modules/posthog-js/dist/rrweb.js |
| 267.7 KiB | ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js |
| 235.5 KiB | src/taxonomy/core-filter-definitions-by-group.json |
| 222.9 KiB | ../node_modules/.pnpm/posthog-js@1.402.3/node_modules/posthog-js/dist/module.js |
| 164.0 KiB | src/queries/validators.js |
| 154.3 KiB | ../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js |
| 126.8 KiB | ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js |
| 105.8 KiB | src/lib/api.ts |
| 93.3 KiB | ../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js |
| 92.7 KiB | ../packages/quill/packages/quill/dist/index.js |
Posted automatically by check-eager-graph · sizes are eager output bytes (shipped, post-tree-shake) from the esbuild metafile · part of #32479
✅ Dist folder size — 🔺 +2.8 KiB (+0.0%)
Total size of the built frontend/dist folder (all assets), compared against the base branch.
Total: 1312.69 MiB · 🔺 +2.8 KiB (+0.0%)
🦔 Hogbox preview · ✅ ready▶ Open the preview
commit |
|
Reviews (1): Last reviewed commit: "Merge branch 'master' into feat/notebook..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
The kernel info panel only renders for markdown (V2) notebook content, so the toggle controls now also require it instead of appearing as no-ops on legacy notebooks. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2 participants
Problem
The kernel UI (kernel info panel toggle in the scene menu bar, the terminal-icon button in the notebook meta bar, and the "Toggle kernel info" items in the SQL run menus) was gated only on the
notebook-pythonfeature flag.Users on the
revamped-py-notebooksflag get SQLV2 nodes that execute through the kernel, but had no way to see kernel info without also enablingnotebook-python.Changes
isKernelUiEnabledhelper infrontend/src/scenes/notebooks/utils.tsthat returns true when eithernotebook-pythonorrevamped-py-notebooksis enabled.FEATURE_FLAGS.NOTEBOOK_PYTHONgates with the helper:NotebookSceneMenuBarkernel info toggleNotebookKernelInfoButtoninNotebookMetaHogqlSqlRunMenuandDuckSqlRunMenuNo backend changes needed since kernel endpoints aren't flag-gated server-side.
How did you test this code?
NotebookMeta.tsxuntouched by this change).typescript:checkreports no errors in the touched files (pre-existing failures exist inproducts/tracingandproducts/review_hog, unrelated).MarkdownNotebookV2RendererUItest path.Automatic notifications
Docs update
Not needed, internal feature-flag gating only.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Authored with Claude Code. Sinan asked for the kernel UI to be visible under the
revamped-py-notebooksflag as well asnotebook-python.Claude located the four frontend gate sites, factored them into a shared helper instead of duplicating the OR at each site, and confirmed there is no backend gating on
notebook-python.🤖 Generated with Claude Code