chore(frontend): inline Kea types batch 9 - #71463
Conversation
🤖 CI report
|
| File | Size | Δ vs base |
|---|---|---|
posthog-app/_parent/products/stamphog/frontend/scenes/StamphogScene/StamphogScene.js |
9.9 KiB | 🔺 +9.9 KiB (new) |
render-query/src/render-query/render-query.js |
21.31 MiB | 🔺 +1.4 KiB (+0.0%) |
Posted automatically by build-bundle-size-report · uncompressed bytes from dist-report
✅ Eager graph — within budget
How much code each root ships on the eager path — downloaded and parsed before the surface is interactive. Measured from the esbuild output chunks (post-tree-shake, static imports only); lazy import() / React.lazy chunks are not counted.
| Root | Eager (shipped) | Δ vs base | Budget |
|---|---|---|---|
entry (logged-out pages, app bootstrap)src/index.tsx |
1.22 MiB · 22 files | no change | ███░░░░░░░ 28.4% of 4.29 MiB |
authenticated shell (every logged-in page)src/scenes/AuthenticatedShell.tsx |
8.14 MiB · 2,981 files | 🔺 +1.4 KiB (+0.0%) | █████████░ 87.9% of 9.25 MiB |
🟢 node_modules/monaco-editor/ stays out of src/index.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/index.tsx
🟢 [object Object] stays out of src/index.tsx
🟢 [object Object] stays out of src/index.tsx
🟢 node_modules/monaco-editor/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
Largest files eagerly shipped from src/index.tsx
| Size | File |
|---|---|
| 126.8 KiB | ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js |
| 24.6 KiB | ../node_modules/.pnpm/buffer@6.0.3/node_modules/buffer/index.js |
| 6.3 KiB | ../node_modules/.pnpm/react@18.3.1/node_modules/react/cjs/react.production.min.js |
| 4.5 KiB | ../node_modules/.pnpm/@jspm+core@2.1.0/node_modules/@jspm/core/nodelibs/browser/process.js |
| 3.9 KiB | ../node_modules/.pnpm/scheduler@0.23.2/node_modules/scheduler/cjs/scheduler.production.min.js |
| 1.4 KiB | ../node_modules/.pnpm/base64-js@1.5.1/node_modules/base64-js/index.js |
| 1.3 KiB | src/RootErrorBoundary.tsx |
| 912 B | ../node_modules/.pnpm/ieee754@1.2.1/node_modules/ieee754/index.js |
| 789 B | src/scenes/ChunkLoadErrorBoundary.tsx |
| 762 B | src/index.tsx |
Largest files eagerly shipped from src/scenes/AuthenticatedShell.tsx
| Size | File |
|---|---|
| 281.3 KiB | ../node_modules/.pnpm/posthog-js@1.402.3/node_modules/posthog-js/dist/rrweb.js |
| 267.7 KiB | ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js |
| 235.5 KiB | src/taxonomy/core-filter-definitions-by-group.json |
| 222.9 KiB | ../node_modules/.pnpm/posthog-js@1.402.3/node_modules/posthog-js/dist/module.js |
| 164.0 KiB | src/queries/validators.js |
| 154.3 KiB | ../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js |
| 126.8 KiB | ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js |
| 105.8 KiB | src/lib/api.ts |
| 93.3 KiB | ../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js |
| 92.7 KiB | ../packages/quill/packages/quill/dist/index.js |
Posted automatically by check-eager-graph · sizes are eager output bytes (shipped, post-tree-shake) from the esbuild metafile · part of #32479
✅ Dist folder size — 🔺 +3.52 MiB (+0.3%)
Total size of the built frontend/dist folder (all assets), compared against the base branch.
Total: 1316.36 MiB · 🔺 +3.52 MiB (+0.3%)
|
Too many files changed for review. ( Bypass the limit by tagging |
👀 Auto-assigned reviewersThese soft owners were skipped because their changes are minor, or the reviewer list was getting long. Nothing blocks merge, so self-assign if you'd like a look:
Soft owners come from each directory's |
🦔 Hogbox preview · ✅ ready▶ Open the preview
commit |
Inline generated Kea types for the ninth balanced migration batch. Generated-By: PostHog Code Task-Id: b1ba4384-4dc4-42ba-a70d-db6542d4fa78
Generated-By: PostHog Code Task-Id: b1ba4384-4dc4-42ba-a70d-db6542d4fa78
Point insight and paths consumers at inlined logic exports and sync stable generator output. Generated-By: PostHog Code Task-Id: b1ba4384-4dc4-42ba-a70d-db6542d4fa78
Generated-By: PostHog Code Task-Id: b1ba4384-4dc4-42ba-a70d-db6542d4fa78
2f13409 to
7ba23ab
Compare
Generated-By: PostHog Code Task-Id: b1ba4384-4dc4-42ba-a70d-db6542d4fa78
|
👋 Visual changes detected for this PR. Review and approve in PostHog Visual Review If these changes are unexpected, they may be caused by a flaky test or a broken snapshot on master. Don't approve — rerun the job or wait for a fix. |
Generated-By: PostHog Code Task-Id: b1ba4384-4dc4-42ba-a70d-db6542d4fa78
Generated-By: PostHog Code Task-Id: b1ba4384-4dc4-42ba-a70d-db6542d4fa78
Generated-By: PostHog Code Task-Id: b1ba4384-4dc4-42ba-a70d-db6542d4fa78
3 participants
Problem
The all-at-once Kea inline type migration is too large to merge safely while logic files keep changing.
Changes
MakeLogicTypedeclarations..kearcslots with its owned folders.Note
Merge foundation PR #71446 first. This PR targets
masterrather than another batch, so sibling merges do not trigger stacked-PR restacks. Its shared foundation diff disappears after #71446 lands.How did you test this code?
kea-typegen write --deleterun that finished with all 1,040 logic types up to date..kearcblock.👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Automatic notifications
Docs update
The shared contributor guidance is in #71446. No user-facing docs change is needed.
🤖 Agent context
Codex generated the full migration once on current
master, partitioned changed files into nine balanced batches, and used preallocated.kearcslots to avoid sibling config conflicts.Autonomy: Human-driven (agent-assisted)
Created with PostHog Code