chore(web-analytics): clean up share nudge experiment - #71522
Conversation
Remove unreachable variant behavior left by the completed share nudge experiment while preserving the active V2 banner and export paths. Generated-By: PostHog Code Task-Id: 2670b225-4340-4758-abb8-2bdc4e94a842
|
Hey @pauldambra! 👋 It looks like your git author email on this PR isn't your
You can fix it for this repo with: git config user.email "you@posthog.com"Or set it globally with |
🤖 CI report✅ Bundle size — 🟢 -9.2 KiB (-0.0%)Uncompressed size of every built Total: 64.79 MiB · 🟢 -9.2 KiB (-0.0%)
Posted automatically by build-bundle-size-report · uncompressed bytes from dist-report ✅ Eager graph — within budgetHow much code each root ships on the eager path — downloaded and parsed before the surface is interactive. Measured from the esbuild output chunks (post-tree-shake, static imports only); lazy
🟢 Largest files eagerly shipped from
|
| Size | File |
|---|---|
| 126.8 KiB | ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js |
| 24.6 KiB | ../node_modules/.pnpm/buffer@6.0.3/node_modules/buffer/index.js |
| 6.3 KiB | ../node_modules/.pnpm/react@18.3.1/node_modules/react/cjs/react.production.min.js |
| 4.5 KiB | ../node_modules/.pnpm/@jspm+core@2.1.0/node_modules/@jspm/core/nodelibs/browser/process.js |
| 3.9 KiB | ../node_modules/.pnpm/scheduler@0.23.2/node_modules/scheduler/cjs/scheduler.production.min.js |
| 1.4 KiB | ../node_modules/.pnpm/base64-js@1.5.1/node_modules/base64-js/index.js |
| 1.3 KiB | src/RootErrorBoundary.tsx |
| 912 B | ../node_modules/.pnpm/ieee754@1.2.1/node_modules/ieee754/index.js |
| 789 B | src/scenes/ChunkLoadErrorBoundary.tsx |
| 762 B | src/index.tsx |
Largest files eagerly shipped from src/scenes/AuthenticatedShell.tsx
| Size | File |
|---|---|
| 281.3 KiB | ../node_modules/.pnpm/posthog-js@1.402.3/node_modules/posthog-js/dist/rrweb.js |
| 267.7 KiB | ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js |
| 235.5 KiB | src/taxonomy/core-filter-definitions-by-group.json |
| 222.9 KiB | ../node_modules/.pnpm/posthog-js@1.402.3/node_modules/posthog-js/dist/module.js |
| 164.0 KiB | src/queries/validators.js |
| 154.3 KiB | ../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js |
| 126.8 KiB | ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js |
| 105.8 KiB | src/lib/api.ts |
| 93.3 KiB | ../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js |
| 92.7 KiB | ../packages/quill/packages/quill/dist/index.js |
Posted automatically by check-eager-graph · sizes are eager output bytes (shipped, post-tree-shake) from the esbuild metafile · part of #32479
✅ Dist folder size — 🔺 +1.01 MiB (+0.1%)
Total size of the built frontend/dist folder (all assets), compared against the base branch.
Total: 1316.41 MiB · 🔺 +1.01 MiB (+0.1%)
🦔 Hogbox preview · ✅ ready▶ Open the preview
commit |
Add focused regression coverage for the four variants in the running V2 experiment, including banner visibility and exposure capture. Generated-By: PostHog Code Task-Id: 2670b225-4340-4758-abb8-2bdc4e94a842
![stamphog[bot]](https://avatars.githubusercontent.com/in/3000332?s=60&v=4){kind=small}
There was a problem hiding this comment.
Straightforward dead-code cleanup removing unreachable experiment variants, with matching test coverage added for the remaining active variants; no risky territory touched, and the author has STRONG familiarity with this exact code despite being off the owning team.
- Author wrote 86% of the modified lines and has 14 merged PRs in these paths (familiarity STRONG).
- 👍 on the PR from chatgpt-codex-connector[bot], hex-security-app[bot].
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 80L, 3F substantive, 112L/4F incl. docs/generated/snapshots — within ceiling |
| tier | ✓ | T1-agent / T1c-medium (112L, 4F, single-area, chore) |
| stamphog 2.0.0b3 | .stamphog/policy.yml @ d0d012d · reviewed head 8a79b37 |
1 participant
Problem
The completed web analytics share-nudge experiment left unreachable variant branches in the active V2 implementation.
Why: Keep the current experiment code aligned with its configured variants and remove obsolete behavior that can no longer run.
Changes
How did you test this code?
git diff --checkcontrol,control_b,banner, andexport. This guards against cleanup accidentally removing a live experiment arm or its exposure event.node_modules,kea-typegen, orhogliinstallation. CI runs the focused frontend validation on the pushed commit.👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Automatic notifications
Docs update
No documentation changes are needed because this removes unreachable experiment code without changing the current V2 workflow.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Codex CLI made the code changes and used the PostHog MCP to audit the experiments and retire the original flag. It invoked
/auditing-experiments-flags,/writing-tests, and/using-kea-disposables. The cleanup keeps the V2bannerandexportvariants while removing only branches that are absent from the V2 flag configuration.Created with PostHog Code