Skip to content

chore(devex): align isolation skill with wiring-couplings turbo inputs - #72044

Draft
posthog[bot] wants to merge 1 commit into
masterfrom
posthog-code/isolation-skill-wiring-inputs
Draft

chore(devex): align isolation skill with wiring-couplings turbo inputs#72044
posthog[bot] wants to merge 1 commit into
masterfrom
posthog-code/isolation-skill-wiring-inputs

Conversation

@posthog

@posthog posthog Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Problem

The isolating-product-facade-contracts skill told authors to narrow backend:contract-check inputs to only backend/facade/** and backend/presentation/**. Since the wiring-couplings doctrine landed (#71486, which updated products/architecture.md), isolated products must keep their designated wiring locations in those inputs too — backend/hogql_queries/**, backend/max_tools.py, backend/temporal/**, backend/tasks/**, plus sanctioned model-registration modules.

Core dispatches through these registered classes with zero facade imports, so a change to a query runner, Max tool, Temporal workflow, or celery task is invisible to tach/import-linter. Following the skill verbatim would leave those changes out of the contract-check inputs, preserving an unsound CI skip for exactly the code core drives.

Changes

  • Rewrote step 6.4 (Narrowed turbo.json inputs) to require facade + presentation, backend/routes.py, and every applicable wiring location and sanctioned model-registration module — framed as required, not optional widening exceptions.
  • Updated the done criteria bullet to match, with a pointer to the § Wiring couplings doctrine.
  • Pointed at products/error_tracking/turbo.json (full worked example) and products/visual_review/turbo.json (minimal: facade + presentation + routes.py + tasks/**), whose actual contents already reflect the new rule.

Docs-only change to a skill; no code paths touched.

How did you test this code?

No automated tests apply — this is a Markdown skill doc. I verified the guidance against the source of truth by reading products/architecture.md § Wiring couplings, .claude/rules/product-isolation.md, and the actual turbo.json files for visual_review and error_tracking, all of which already include the wiring inputs the skill was omitting.

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Docs update

🤖 Agent context

Autonomy: Fully autonomous

Triggered by an inbox report flagging the skill as stale versus the wiring-couplings doctrine. I read the skill, products/architecture.md (updated by #71486), the .claude/rules/product-isolation.md rule, and the reference turbo.json files to confirm the drift, then updated the two spots that enumerated the two-path input set. Skill invoked: /isolating-product-facade-contracts. Left the non-enumerating "narrowed turbo.json" mentions (PR strategy, presentation wave) untouched since they don't restate the stale path list.


Created with PostHog Code from this inbox report.

The isolating-product-facade-contracts skill told authors to narrow
backend:contract-check inputs to only backend/facade/** and
backend/presentation/**. Since the wiring-couplings doctrine (#71486),
core-dispatched implementations (query runners, Max tools, Temporal
workflows, celery tasks) and sanctioned model-registration modules must
stay in those inputs so a change to them still re-runs the full suite.
Following the skill verbatim preserved an unsound CI skip.

Update step 6.4 and the done criteria to require the wiring locations
(and backend/routes.py) alongside facade/presentation, and point at the
error_tracking and visual_review turbo.json examples.

Generated-By: PostHog Code
Task-Id: f15e5796-88fe-432e-8301-938605c272ba
@scheduled-actions-posthog

Copy link
Copy Markdown
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, please remove the stale label – otherwise this will be closed in another week. If you want to permanently keep it open, use the waiting label.

@trunk-io

trunk-io Bot commented Jul 28, 2026

Copy link
Copy Markdown

Merging to master in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants