Skip to content

chore(review_hog): clarify in-progress status comment wording - #72517

Merged
pauldambra merged 4 commits into
masterfrom
posthog-code/review-hog-status-wording
Jul 21, 2026
Merged

chore(review_hog): clarify in-progress status comment wording#72517
pauldambra merged 4 commits into
masterfrom
posthog-code/review-hog-status-wording

Conversation

@pauldambra

Copy link
Copy Markdown
Member

Problem

The ReviewHog in-progress PR comment described specialist reviewers as "perspectives" reading code "in parallel," which reads as a passive description rather than reflecting that each reviewer is a distinct skill applying its own lens.

Changes

  • Reworded the explainer sentence in render_in_progress_body (products/review_hog/backend/reviewer/status_comment.py) to: "Specialist review skills read the changed code in parallel each from their own perspective…"

How did I test this code?

  • ruff check + ruff format --check on the changed file pass.
  • Confirmed no tests assert on the exact sentence wording, so the string change is safe.
  • Agent: did not run the ReviewHog test suite or exercise comment rendering end to end; verified only that no existing test pins this specific string.

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Docs update

N/A — user-facing copy in a bot-generated PR comment, not a doc.

🤖 Agent context

Autonomy: Fully autonomous

  • Changed the one-line explainer in the ReviewHog in-progress status comment per a direct wording request; "perspectives" → "skills … each from their own perspective."
  • No skills invoked — this is a one-line copy edit; no DRF/serializer/migration/test-code touched.
  • Checked that no test pins the exact phrase before editing.

Created with PostHog Code

Generated-By: PostHog Code
Task-Id: f8d3b172-1baf-4de0-bd09-82c6b0eb9559
@pauldambra pauldambra added the stamphog Request AI approval (no full review) label Jul 21, 2026 — with PostHog
@pauldambra
pauldambra marked this pull request as ready for review July 21, 2026 10:06
@pauldambra
pauldambra enabled auto-merge (squash) July 21, 2026 10:06
@github-actions

Copy link
Copy Markdown
Contributor

Hey @pauldambra! 👋

It looks like your git author email on this PR isn't your @posthog.com address (paul.dambra@gmail.com). Since you're on the PostHog team, it's worth pointing your local git author email at your @posthog.com address. Why it matters:

  • Consistent work identity in git history — internal tooling that attributes commits to team members keys off your @posthog.com address.
  • Keeps team contributions easy to tell apart from external community ones when scanning history.

You can fix it for this repo with:

git config user.email "you@posthog.com"

Or set it globally with git config --global user.email "you@posthog.com". No need to redo this PR — just a nudge for next time. 🙂

@pr-assigner-resolver-posthog
pr-assigner-resolver-posthog Bot requested a review from a team July 21, 2026 10:06
Apply the same "skills ... each from their own perspective" wording to the
two user-facing ReviewHog settings-page explainer paragraphs that mirrored
the PR status comment: the page intro and the "Review skills" section intro.
Previously both still said "perspectives read".

Generated-By: PostHog Code
Task-Id: f8d3b172-1baf-4de0-bd09-82c6b0eb9559
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

🦔 Hogbox preview · ✅ ready

▶ Open the preview

🔑 Login test@posthog.com / 12345678 (demo data)
🧩 Running this PR's backend and frontend, on the PostHog :master base
🔗 Link stable across rebuilds — a re-push swaps the box underneath, the URL stays
🔒 Access tailnet only (PostHog VPN)
🛠️ Admin inspect & debug state in hogland
💤 Idle sleeps after ~30 min idle (snapshot to S3, zero node cost) and wakes on your next visit in ~30s, behind a brief "waking up" screen

commit 0e96344 · box box-e68bcf6f04ba · ready in 840s (push → usable) · build log · rebuilds on every push, torn down on close

stamphog[bot]
stamphog Bot previously approved these changes Jul 21, 2026

@stamphog stamphog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Purely cosmetic wording tweak to a UI/comment string, no behavior change; low-risk trivial tier despite lacking reviews.

  • 👍 on the PR from chatgpt-codex-connector[bot], hex-security-app[bot].
Gate mechanics and policy version
Gate Result
prerequisites all clear
deny-list no deny categories matched
size 6L, 2F substantive — within ceiling
tier T1-agent / T1a-trivial (6L, 2F, single-area, chore)
stamphog 2.0.0b3 .stamphog/policy.yml @ d9723b1 · reviewed head 99e5ac2

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

🤖 CI report

⚠️ Bundle size — 🔺 +27 B (+0.0%)

Uncompressed size of every built .js bundle, compared against the base branch.

Total: 64.29 MiB · 🔺 +27 B (+0.0%)

No file changed by more than 1000 B.

Posted automatically by build-bundle-size-report · uncompressed bytes from dist-report

Eager graph — within budget

How much code each root ships on the eager path — downloaded and parsed before the surface is interactive. Measured from the esbuild output chunks (post-tree-shake, static imports only); lazy import() / React.lazy chunks are not counted.

Root Eager (shipped) Δ vs base Budget
entry (logged-out pages, app bootstrap)
src/index.tsx
1.23 MiB · 22 files no change ███░░░░░░░ 28.6% of 4.29 MiB
authenticated shell (every logged-in page)
src/scenes/AuthenticatedShell.tsx
8.18 MiB · 2,997 files no change █████████░ 88.5% of 9.25 MiB

🟢 node_modules/monaco-editor/ stays out of src/index.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/index.tsx
🟢 [object Object] stays out of src/index.tsx
🟢 [object Object] stays out of src/index.tsx
🟢 node_modules/monaco-editor/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx

Largest files eagerly shipped from src/index.tsx
Size File
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
24.6 KiB ../node_modules/.pnpm/buffer@6.0.3/node_modules/buffer/index.js
6.3 KiB ../node_modules/.pnpm/react@18.3.1/node_modules/react/cjs/react.production.min.js
4.5 KiB ../node_modules/.pnpm/@jspm+core@2.1.0/node_modules/@jspm/core/nodelibs/browser/process.js
3.9 KiB ../node_modules/.pnpm/scheduler@0.23.2/node_modules/scheduler/cjs/scheduler.production.min.js
1.4 KiB ../node_modules/.pnpm/base64-js@1.5.1/node_modules/base64-js/index.js
1.3 KiB src/RootErrorBoundary.tsx
912 B ../node_modules/.pnpm/ieee754@1.2.1/node_modules/ieee754/index.js
789 B src/scenes/ChunkLoadErrorBoundary.tsx
762 B src/index.tsx
Largest files eagerly shipped from src/scenes/AuthenticatedShell.tsx
Size File
281.3 KiB ../node_modules/.pnpm/posthog-js@1.404.1/node_modules/posthog-js/dist/rrweb.js
267.7 KiB ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js
235.8 KiB src/taxonomy/core-filter-definitions-by-group.json
223.4 KiB ../node_modules/.pnpm/posthog-js@1.404.1/node_modules/posthog-js/dist/module.js
167.1 KiB src/queries/validators.js
154.3 KiB ../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
105.9 KiB src/lib/api.ts
93.3 KiB ../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js
93.2 KiB ../packages/quill/packages/quill/dist/index.js

Posted automatically by check-eager-graph · sizes are eager output bytes (shipped, post-tree-shake) from the esbuild metafile · part of #32479

Dist folder size — 🔺 +79 B (+0.0%)

Total size of the built frontend/dist folder (all assets), compared against the base branch.

Total: 1352.07 MiB · 🔺 +79 B (+0.0%)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@stamphog
stamphog Bot dismissed their stale review July 21, 2026 10:32

New commits pushed (delta classified non_trivial_delta) — stamphog approval dismissed; re-review running automatically.

@stamphog stamphog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial wording-only copy edit across two files, no logic or risky territory touched.

  • 👍 on the PR from chatgpt-codex-connector[bot], hex-security-app[bot].
Gate mechanics and policy version
Gate Result
prerequisites all clear
deny-list no deny categories matched
size 9L, 2F substantive — within ceiling
tier T1-agent / T1a-trivial (9L, 2F, single-area, chore)
stamphog 2.0.0b3 .stamphog/policy.yml @ fe16630 · reviewed head f52c0fa

Copy link
Copy Markdown
Member Author

⚠️ Python code quality is failing on a pre-existing master breakage, not this PR's changes

The required Python code quality check fails with:

F821 Undefined name `TRANSPORT`
 --> products/warehouse_sources/backend/temporal/data_imports/sources/webflow/tests/test_webflow.py:233:20

This is not caused by this PR. The file isn't in this PR's diff (this PR only touches products/review_hog/...).

Root cause

On master, commit 78ee7739 (PR #72505, "fix(webflow): surface a clear error for an invalid Site ID") added test_invalid_site_id_400_does_not_leak_raw_envelope, which patches TRANSPORT. But that constant was renamed earlier in 7e580cbd (PR #72023) to WEBFLOW_SESSION_PATCH / CLIENT_SESSION_PATCH. The new test was never updated, so TRANSPORT is now undefined.

master itself is currently red on the same error (run 29822670530), so every open PR merged with master hits this.

Fix (for the webflow owners)

One-liner at test_webflow.py:233 — the test calls validate_credentials(...), matching the sibling test_status_mapping right above it which patches WEBFLOW_SESSION_PATCH:

-        with patch(TRANSPORT) as MockSession:
+        with patch(WEBFLOW_SESSION_PATCH) as MockSession:

This PR's own changes are clean

  • ruff check passes on products/review_hog/backend/reviewer/status_comment.py (reproduced with CI's exact ruff 0.15.20).
  • Frontend typecheck job passes.

I'm leaving the webflow fix off this branch since it's outside this PR's scope; once master is fixed, re-running CI here will go green. Happy to open a separate fix PR for the webflow constant if that's preferred — let me know.

@pauldambra
pauldambra merged commit 7b7de1b into master Jul 21, 2026
263 checks passed
@pauldambra
pauldambra deleted the posthog-code/review-hog-status-wording branch July 21, 2026 11:46
@deployment-status-posthog

deployment-status-posthog Bot commented Jul 21, 2026

Copy link
Copy Markdown

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-07-21 12:10 UTC Run
prod-us ✅ Deployed 2026-07-21 12:31 UTC Run
prod-eu ✅ Deployed 2026-07-21 12:30 UTC Run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stamphog Request AI approval (no full review)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant