Skip to content

feat(review-hog): randomize clean review media - #73029

Merged
pauldambra merged 5 commits into
masterfrom
posthog-code/randomize-reviewhog-clean-media
Jul 22, 2026
Merged

feat(review-hog): randomize clean review media#73029
pauldambra merged 5 commits into
masterfrom
posthog-code/randomize-reviewhog-clean-media

Conversation

@pauldambra

@pauldambra pauldambra commented Jul 22, 2026

Copy link
Copy Markdown
Member

Problem

Why: Clean ReviewHog runs always show the same GIF. A small media pool keeps the reward varied and makes future additions straightforward without growing the main repository.

Changes

  • Randomly select from two GIFs and an optimized dog image.
  • Store all assets in the public asset repository behind permanent SHA-pinned URLs.

How did you test this code?

  • uv run pytest -q products/review_hog/backend/tests/test_status_comment.py::TestRenderFinalBody (6 passed). The new case catches regressions where the selected media URL and alt text are not rendered.
  • ruff check and hogli ci:preflight --fix passed.
  • The full status-comment test file reached 10 passing tests, but its 8 database-backed tests could not start because Postgres was unavailable in this environment.

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Docs update

No docs update is needed. This only varies the media in an existing GitHub status comment.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

PostHog Code (Codex) implemented the change and used the /writing-tests skill to keep coverage focused on the observable rendered comment. The supplied dog image was reduced from 3.9 MB to 141 KB. The supplied panda GIF was reduced from 2.1 MB to 576 KB while preserving its animation. The main repository stores only their pinned URLs.


Created with PostHog Code

Generated-By: PostHog Code
Task-Id: 2d202d67-1a18-4ce3-95ed-1b0f0fdd5817
@pauldambra pauldambra self-assigned this Jul 22, 2026
@trunk-io

trunk-io Bot commented Jul 22, 2026

Copy link
Copy Markdown

😎 This pull request was merged.

@github-actions

Copy link
Copy Markdown
Contributor

Hey @pauldambra! 👋

It looks like your git author email on this PR isn't your @posthog.com address (paul.dambra@gmail.com). Since you're on the PostHog team, it's worth pointing your local git author email at your @posthog.com address. Why it matters:

  • Consistent work identity in git history — internal tooling that attributes commits to team members keys off your @posthog.com address.
  • Keeps team contributions easy to tell apart from external community ones when scanning history.

You can fix it for this repo with:

git config user.email "you@posthog.com"

Or set it globally with git config --global user.email "you@posthog.com". No need to redo this PR — just a nudge for next time. 🙂

Generated-By: PostHog Code
Task-Id: 2d202d67-1a18-4ce3-95ed-1b0f0fdd5817
Generated-By: PostHog Code
Task-Id: 2d202d67-1a18-4ce3-95ed-1b0f0fdd5817
Generated-By: PostHog Code
Task-Id: 2d202d67-1a18-4ce3-95ed-1b0f0fdd5817
Generated-By: PostHog Code
Task-Id: 2d202d67-1a18-4ce3-95ed-1b0f0fdd5817
@pauldambra
pauldambra marked this pull request as ready for review July 22, 2026 22:45
@pauldambra pauldambra added the stamphog Request AI approval (no full review) label Jul 22, 2026
@pauldambra
pauldambra enabled auto-merge (squash) July 22, 2026 22:45
@pr-assigner-resolver-posthog
pr-assigner-resolver-posthog Bot requested a review from a team July 22, 2026 22:45

@stamphog stamphog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low-risk, contained change swapping a single hardcoded GIF for a random pick among three pinned static assets in a status-comment renderer; diff matches description, has test coverage, and carries a current-head approval.

  • andrewm4894 reviewed the current head.
Gate mechanics and policy version
Gate Result
prerequisites all clear
deny-list no deny categories matched
size 30L, 1F substantive, 46L/2F incl. docs/generated/snapshots — within ceiling
tier T1-agent / T1b-small (46L, 2F, single-area, feat)
stamphog 2.0.0b3 .stamphog/policy.yml @ 53b7152 · reviewed head 9ff7d6c

@pauldambra
pauldambra merged commit 5f13a28 into master Jul 22, 2026
376 of 417 checks passed
@pauldambra
pauldambra deleted the posthog-code/randomize-reviewhog-clean-media branch July 22, 2026 23:13
@deployment-status-posthog

deployment-status-posthog Bot commented Jul 22, 2026

Copy link
Copy Markdown

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-07-22 23:41 UTC Run
prod-us ✅ Deployed 2026-07-22 23:57 UTC Run
prod-eu ✅ Deployed 2026-07-22 23:59 UTC Run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stamphog Request AI approval (no full review)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants