Skip to content

fix(error-tracking): drop --region flag from source maps wizard command - #73263

Merged
ablaszkiewicz merged 3 commits into
masterfrom
ab/fix/et-wizard-no-region
Jul 24, 2026
Merged

fix(error-tracking): drop --region flag from source maps wizard command#73263
ablaszkiewicz merged 3 commits into
masterfrom
ab/fix/et-wizard-no-region

Conversation

@ablaszkiewicz

Copy link
Copy Markdown
Contributor

Problem

The source maps upload recommendation tells users to run npx -y @posthog/wizard@latest upload-source-maps, and on EU Cloud we appended --region eu. The wizard already resolves the region from the access token, so the flag is redundant noise in the command we hand people.

Changes

Drop the --region eu suffix everywhere the source maps recommendation renders the wizard command:

  • weekly_digest.py_source_maps_wizard_command() now returns the plain command
  • missing_source_maps.py health check — WIZARD_COMMAND constant (also drops the now-unused get_instance_region import)
  • sourceMapsFixWizardLogic.tswizardCommand selector is now a constant (drops the preflightLogic / Region dependencies)
  • error-tracking-recommendations-list.md MCP prompt — removes the "append --region eu for EU projects" note

Left the headless cloud-run wizard in products/tasks/.../run_wizard.py untouched: it runs non-interactively in a sandbox where a local access key can't infer a region, so it passes --region deliberately.

How did you test this code?

Ran TestSourceMapsRecommendationForDigest (7 passed). Removed the now-obsolete test_wizard_command_appends_region_eu_on_eu_cloud case. Frontend typecheck shows no errors in the touched logic.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

I (Claude) made this change on request. Swept the repo for --region appended to the wizard command, found four recommendation surfaces plus the headless task runner, and changed only the four user-facing recommendation spots. No skills were required for this change.

The @posthog/wizard upload-source-maps command auto-detects the region
from the access token, so the appended --region eu flag is redundant.
Remove it from all four places the recommendation surfaces it: the
weekly digest, the health check remediation, the frontend fix modal, and
the MCP recommendations prompt.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ablaszkiewicz ablaszkiewicz self-assigned this Jul 23, 2026
@ablaszkiewicz
ablaszkiewicz marked this pull request as ready for review July 23, 2026 15:03
Copilot AI review requested due to automatic review settings July 23, 2026 15:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@ablaszkiewicz
ablaszkiewicz enabled auto-merge (squash) July 23, 2026 15:03
@github-actions
github-actions Bot requested a deployment to preview-pr-73263 July 23, 2026 15:03 In progress
@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

🦔 Hogbox preview · ✅ ready

▶ Open the preview

🔑 Login test@posthog.com / 12345678 (demo data)
🧩 Running this PR's backend and frontend, on the PostHog :master base
🔗 Link stable across rebuilds — a re-push swaps the box underneath, the URL stays
🔒 Access tailnet only (PostHog VPN)
🛠️ Admin inspect & debug state in hogland
💤 Idle sleeps after ~30 min idle (snapshot to S3, zero node cost) and wakes on your next visit in ~30s, behind a brief "waking up" screen

commit 0c67518 · box box-b3f5440b64fc · ready in 1341s (push → usable) · build log · rebuilds on every push, torn down on close

@pr-assigner-resolver-posthog
pr-assigner-resolver-posthog Bot requested review from a team, cat-ph and hpouillot July 23, 2026 15:03
@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

🤖 CI report

⚠️ Bundle size — 🔺 +613 B (+0.0%)

Uncompressed size of every built .js bundle, compared against the base branch.

Total: 64.68 MiB · 🔺 +613 B (+0.0%)

No file changed by more than 1000 B.

Posted automatically by build-bundle-size-report · uncompressed bytes from dist-report

Eager graph — within budget

How much code each root ships on the eager path — downloaded and parsed before the surface is interactive. Measured from the esbuild output chunks (post-tree-shake, static imports only); lazy import() / React.lazy chunks are not counted.

Root Eager (shipped) Δ vs base Budget
entry (logged-out pages, app bootstrap)
src/index.tsx
1.24 MiB · 22 files no change ███░░░░░░░ 27.5% of 4.51 MiB
authenticated shell (every logged-in page)
src/scenes/AuthenticatedShell.tsx
8.25 MiB · 3,014 files 🔺 +663 B (+0.0%) ████████░░ 84.9% of 9.71 MiB

🟢 node_modules/monaco-editor/ stays out of src/index.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/index.tsx
🟢 [object Object] stays out of src/index.tsx
🟢 [object Object] stays out of src/index.tsx
🟢 node_modules/monaco-editor/ stays out of src/scenes/AuthenticatedShell.tsx
🟢 src/lib/components/ActivityLog/describers stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx
🟢 [object Object] stays out of src/scenes/AuthenticatedShell.tsx

Largest files eagerly shipped from src/index.tsx
Size File
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
24.6 KiB ../node_modules/.pnpm/buffer@6.0.3/node_modules/buffer/index.js
6.3 KiB ../node_modules/.pnpm/react@18.3.1/node_modules/react/cjs/react.production.min.js
4.5 KiB ../node_modules/.pnpm/@jspm+core@2.1.0/node_modules/@jspm/core/nodelibs/browser/process.js
3.9 KiB ../node_modules/.pnpm/scheduler@0.23.2/node_modules/scheduler/cjs/scheduler.production.min.js
1.4 KiB ../node_modules/.pnpm/base64-js@1.5.1/node_modules/base64-js/index.js
1.3 KiB src/RootErrorBoundary.tsx
912 B ../node_modules/.pnpm/ieee754@1.2.1/node_modules/ieee754/index.js
789 B src/scenes/ChunkLoadErrorBoundary.tsx
762 B src/index.tsx
Largest files eagerly shipped from src/scenes/AuthenticatedShell.tsx
Size File
281.5 KiB ../node_modules/.pnpm/posthog-js@1.407.1/node_modules/posthog-js/dist/rrweb.js
267.7 KiB ../node_modules/.pnpm/@posthog+icons@0.38.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js
236.0 KiB src/taxonomy/core-filter-definitions-by-group.json
226.1 KiB ../node_modules/.pnpm/posthog-js@1.407.1/node_modules/posthog-js/dist/module.js
167.1 KiB src/queries/validators.js
154.3 KiB ../node_modules/.pnpm/re2js@0.4.1/node_modules/re2js/build/index.esm.js
126.8 KiB ../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js
105.8 KiB src/lib/api.ts
94.0 KiB ../packages/quill/packages/quill/dist/index.js
93.3 KiB ../node_modules/.pnpm/prosemirror-view@1.40.1/node_modules/prosemirror-view/dist/index.js

Posted automatically by check-eager-graph · sizes are eager output bytes (shipped, post-tree-shake) from the esbuild metafile · part of #32479

Toolbar bundle — eager 2.18 MiB within budget

What the toolbar ships to customer pages, measured from the esbuild output (minified, post-tree-shake). The eager set is the entry plus everything statically imported from it — fetched before any feature runs; deferred chunks load lazily. The eager guardrail is 5.72 MiB. Each output file must also stay below 10 MB, where CloudFront stops compressing it. The module boundary is enforced separately by check-toolbar-graph.

Metric Size Δ vs base Budget
Eager (shipped)
entry + static imports
2.18 MiB · 17 files no change ████░░░░░░ 38.1% of 5.72 MiB
Deferred (lazy) 2.07 MiB · 33 files no change n/a — loads on demand
Loader dist/toolbar.js 1.1 KiB no change █░░░░░░░░░ 5.8% of 19.5 KiB
Largest eagerly-shipped chunks
Size File
714.7 KiB dist/toolbar/toolbar-app-MKBF64XP.css
545.3 KiB dist/toolbar/chunk-chunk-HYYFIAXK.js
484.2 KiB dist/toolbar/chunk-chunk-QS5AHYGW.js
133.6 KiB dist/toolbar/chunk-chunk-3HAV52CR.js
131.8 KiB dist/toolbar/chunk-chunk-T5KY5WYR.js
71.0 KiB dist/toolbar/toolbar-app-4WXEV7ZF.js
69.0 KiB dist/toolbar/chunk-chunk-27JL52RE.js
35.6 KiB dist/toolbar/chunk-chunk-EL3T2QEA.js
20.9 KiB dist/toolbar/chunk-chunk-HSIJKX5O.js
12.2 KiB dist/toolbar/chunk-chunk-PIK3PADE.js

Posted automatically by check-toolbar-size · sizes are toolbar output bytes (shipped, post-tree-shake) from the esbuild metafile

Dist folder size — 🔺 +16.2 KiB (+0.0%)

Total size of the built frontend/dist folder (all assets), compared against the base branch.

Total: 1359.31 MiB · 🔺 +16.2 KiB (+0.0%)

ℹ️ MCP UI apps size — 32 app(s), 17065.5 KB JS

Built size of each MCP UI app (main.js + styles.css).

App JS CSS
debug 599.5 KB 187.7 KB
action 457.8 KB 187.7 KB
action-list 564.3 KB 187.7 KB
cohort 456.8 KB 187.7 KB
cohort-list 563.3 KB 187.7 KB
email-template 456.6 KB 187.7 KB
error-details 472.4 KB 187.7 KB
error-issue 457.5 KB 187.7 KB
error-issue-list 564.2 KB 187.7 KB
experiment 561.5 KB 187.7 KB
experiment-list 565.1 KB 187.7 KB
experiment-results 563.2 KB 187.7 KB
feature-flag 567.1 KB 187.7 KB
feature-flag-list 570.9 KB 187.7 KB
feature-flag-testing 461.0 KB 187.7 KB
insight-actors 562.1 KB 187.7 KB
invite-email-preview 456.0 KB 187.7 KB
llm-costs 559.5 KB 187.7 KB
session-recording 458.6 KB 187.7 KB
session-summary 463.9 KB 187.7 KB
survey 458.4 KB 187.7 KB
survey-global-stats 562.2 KB 187.7 KB
survey-list 565.0 KB 187.7 KB
survey-stats 562.2 KB 187.7 KB
trace-span 457.2 KB 187.7 KB
trace-span-list 564.2 KB 187.7 KB
workflow 457.1 KB 187.7 KB
workflow-list 563.7 KB 187.7 KB
loops-review 461.2 KB 187.7 KB
query-results 745.5 KB 187.7 KB
render-ui 826.2 KB 187.7 KB
visual-review-snapshots 461.6 KB 187.7 KB

@greptile-apps

greptile-apps Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "fix(error-tracking): drop --region flag ..." | Re-trigger Greptile

@tests-posthog
tests-posthog Bot disabled auto-merge July 23, 2026 15:13
@github-actions
github-actions Bot requested a deployment to preview-pr-73263 July 23, 2026 15:13 In progress
…logic

The wizardCommand selector no longer has input dependencies, so kea-typegen
drops the generated Meta interface and simplifies MakeLogicType. Commit the
canonical output so the frontend typegen check passes.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ablaszkiewicz
ablaszkiewicz merged commit 820d6c2 into master Jul 24, 2026
266 checks passed
@ablaszkiewicz
ablaszkiewicz deleted the ab/fix/et-wizard-no-region branch July 24, 2026 06:56
@deployment-status-posthog

deployment-status-posthog Bot commented Jul 24, 2026

Copy link
Copy Markdown

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-07-24 07:22 UTC Run
prod-us ✅ Deployed 2026-07-24 07:38 UTC Run
prod-eu ✅ Deployed 2026-07-24 07:38 UTC Run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants