Skip to content

fix(eng-analytics): report product test spans - #73290

Merged
rnegron merged 1 commit into
masterfrom
fix/eng-analytics-product-junit-spans
Jul 24, 2026
Merged

fix(eng-analytics): report product test spans#73290
rnegron merged 1 commit into
masterfrom
fix/eng-analytics-product-junit-spans

Conversation

@rnegron

@rnegron rnegron commented Jul 23, 2026

Copy link
Copy Markdown
Member

Problem

  • Product-test JUnit artifacts use a separate prefix, so the timing reporter never downloads them and Engineering Analytics receives no product-test spans.

Changes

flowchart LR
P[Product JUnit] --> A[Product artifact]
A -. excluded .-> R[Timing reporter]
Loading
flowchart LR
P[Product JUnit] --> A[Product artifact] --> R[Timing reporter] --> S[Test-health spans]
Loading
  • Download both existing artifact prefixes without renaming producers.
  • Reconstruct repository-relative product paths before span naming, selectors, and ownership lookup.
  • Keep missing artifacts and telemetry best effort.

How did you test this code?

  • Reporter tests: 41 passed. The new case catches product-relative paths losing ownership context.
  • Workflow lint, actionlint, Ruff, and CI preflight passed.

Automatic notifications

  • Publish to changelog?
  • Alert Sales and Marketing teams?

Docs update

None.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

  • Codex implemented this as an independent prerequisite fix. Skills: wt, authoring-ci-workflows, writing-tests.
  • The existing artifact contract remains compatible with open PRs and the Trunk-removal PR.

@rnegron rnegron self-assigned this Jul 23, 2026
@rnegron
rnegron marked this pull request as ready for review July 23, 2026 16:37
@rnegron rnegron added the stamphog Request AI approval (no full review) label Jul 23, 2026
@pr-assigner-resolver-posthog
pr-assigner-resolver-posthog Bot requested a review from a team July 23, 2026 16:38
@stamphog

stamphog Bot commented Jul 23, 2026

Copy link
Copy Markdown

Note

🤖 stamphog reviewed 32d5b0be57c493ca34dd4a4c756cd239fb2c2033 — verdict: REFUSED

Gates denied this PR (CI/deploy workflow changes hit the infra_cicd deny-list and the change is classified T2-never), so it requires human review regardless of diff quality; the change itself looks reasonable and the earlier Greptile P1 concern appears fixed, but policy doesn't allow auto-approval past a denied gate.

  • 👍 on the PR from greptile-apps[bot], hex-security-app[bot].
  • Gate verdict DENIED: deny-list match on infra_cicd (CI workflow changes to .github/workflows/ci-backend.yml and .depot/workflows/ci-backend.yml)
  • Tier classified as T2-never, which requires human sign-off by policy
Gate mechanics and policy version
Gate Result
prerequisites all clear
deny-list matches: infra_cicd
size 50L, 3F substantive, 91L/4F incl. docs/generated/snapshots — within ceiling
tier classified as T2-never: T2-never (91L, 4F, two-areas, fix)
stamphog 2.0.0b3 .stamphog/policy.yml @ 38d3899 · reviewed head 32d5b0b

Updated in place — this replaces 1 earlier stamphog review(s) on this PR.

@stamphog stamphog Bot removed the stamphog Request AI approval (no full review) label Jul 23, 2026
@greptile-apps

greptile-apps Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
.github/workflows/ci-backend.yml:3571
**Product artifact metadata is misparsed**

When this pattern adds `product-junit-results-<index>` directories to the reporter, its parser only removes a leading `junit-results-` prefix, so product spans receive the incorrect suite and segment `product-junit-results`, causing misleading trace names and trace keys.

Reviews (1): Last reviewed commit: "fix(eng-analytics): report product test ..." | Re-trigger Greptile

Comment thread .github/workflows/ci-backend.yml
@rnegron rnegron added the stamphog Request AI approval (no full review) label Jul 23, 2026
@stamphog stamphog Bot removed the stamphog Request AI approval (no full review) label Jul 23, 2026
@rnegron
rnegron force-pushed the fix/eng-analytics-product-junit-spans branch from b425505 to 2006922 Compare July 23, 2026 20:22
@rnegron
rnegron force-pushed the fix/eng-analytics-product-junit-spans branch from 7c7780b to a5b113d Compare July 23, 2026 22:55
@rnegron
rnegron enabled auto-merge (squash) July 24, 2026 13:06
@rnegron
rnegron merged commit 791c189 into master Jul 24, 2026
244 checks passed
@rnegron
rnegron deleted the fix/eng-analytics-product-junit-spans branch July 24, 2026 14:55
@deployment-status-posthog

deployment-status-posthog Bot commented Jul 24, 2026

Copy link
Copy Markdown

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-07-24 15:29 UTC Run
prod-us ✅ Deployed 2026-07-24 15:58 UTC Run
prod-eu ✅ Deployed 2026-07-24 15:59 UTC Run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants