fix(eng-analytics): report product test spans - #73290
Merged
Merged
Conversation
|
Note 🤖 stamphog reviewed Gates denied this PR (CI/deploy workflow changes hit the infra_cicd deny-list and the change is classified T2-never), so it requires human review regardless of diff quality; the change itself looks reasonable and the earlier Greptile P1 concern appears fixed, but policy doesn't allow auto-approval past a denied gate.
Gate mechanics and policy version
Updated in place — this replaces 1 earlier stamphog review(s) on this PR. |
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
.github/workflows/ci-backend.yml:3571
**Product artifact metadata is misparsed**
When this pattern adds `product-junit-results-<index>` directories to the reporter, its parser only removes a leading `junit-results-` prefix, so product spans receive the incorrect suite and segment `product-junit-results`, causing misleading trace names and trace keys.
Reviews (1): Last reviewed commit: "fix(eng-analytics): report product test ..." | Re-trigger Greptile |
rnegron
force-pushed
the
fix/eng-analytics-product-junit-spans
branch
from
July 23, 2026 20:22
b425505 to
2006922
Compare
rnegron
force-pushed
the
fix/eng-analytics-product-junit-spans
branch
from
July 23, 2026 22:55
7c7780b to
a5b113d
Compare
rnegron
enabled auto-merge (squash)
July 24, 2026 13:06
gantoine
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Changes
How did you test this code?
Automatic notifications
Docs update
None.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
wt,authoring-ci-workflows,writing-tests.