chore(desktop): rename inbox signal source group to "External sources" - #76579
Draft
joshsny wants to merge 1 commit into
Draft
chore(desktop): rename inbox signal source group to "External sources"#76579joshsny wants to merge 1 commit into
joshsny wants to merge 1 commit into
Conversation
Matches the "Connected tools"/"External sources" naming used in the main app so the inbox signal-sources section is consistent across surfaces. Label-only change, no behavior change. Generated-By: PostHog Code Task-Id: 40710cb7-2e49-43a6-b7a9-2812ca5250ae
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
2 tasks
Contributor
|
Hey @joshsny! 👋 It looks like your git author email on this PR isn't your
You can fix it for this repo with: git config user.email "you@posthog.com"Or set it globally with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The inbox signal-sources section groups external integrations under a header that does not match its counterpart in the main PostHog app ("Connected tools" there, "External connections" here). The naming should be consistent across both surfaces.
This is a port of PostHog/code#3967, which was approved and green but can never merge: PostHog/code is now frozen behind a "block all PRs" ruleset after the monorepo migration, so the ref cannot be updated there.
Changes
Renames the signal-sources group header (and its loading skeleton) from External connections to External sources, matching the sibling "PostHog data" group.
How did you test this code?
I (actually the PostHog Slack agent) did not run the app or any tests for this. It is a two-string copy change in one component, ported byte-for-byte from the already-approved and fully-green PostHog/code#3967, and I verified by grep that the live header and the skeleton header are the only occurrences.
Automatic notifications
🤖 Agent context
Human-driven (agent-assisted). Ported by the PostHog Slack agent at the request of the original PR's author, who is assigned as DRI.
Created with PostHog from a Slack thread