Skip to content

fix(desktop): hide internal artifacts from task timeline - #83102

Merged
trunk-io[bot] merged 1 commit into
masterfrom
posthog/fix-internal-artifact-timeline-events
Aug 14, 2026
Merged

fix(desktop): hide internal artifacts from task timeline#83102
trunk-io[bot] merged 1 commit into
masterfrom
posthog/fix-internal-artifact-timeline-events

Conversation

@puemos

@puemos puemos commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Problem

Task timelines show git checkpoint files as agent-created deliverables after cloud file edits.

The artifact upload path announced every agent upload, including internal files used to restore a run.

Changes

  • Announce only run artifacts classified as task outputs.
  • Hide historical events for non-output run artifact types.
  • Keep living artifacts and task output revisions visible.
  • No screenshot: this changes which rows appear, not their rendering.

How did you test this code?

  • Extended the backend thread test to catch internal uploads that create timeline messages.
  • Ran the desktop core typecheck and test suite to cover historical event filtering.
  • Ran the handoff checkpoint tests to confirm checkpoint capture and restore still work.
  • Ran the task thread update test suite, Ruff, Biome, and CI preflight.
  • Repo-wide mypy did not complete because the sandbox ran out of memory.
  • I did not run a manual desktop session.

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Automatic notifications

  • Publish to changelog?

Docs update

No docs update. This fixes unintended rows in an existing timeline without changing its documented workflow.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

  • Agent: GPT-5.6 through PostHog Desktop. Session
  • Skills: /querying-posthog-data, /working-with-task-comments, /writing-simplified-technical-english, /writing-tests, /writing-code-comments, and /writing-pr-descriptions.
  • I compared task run manifests with session logs, then added filters at the producer and desktop parser.
  • The task included private report context. The committed fixture is invented and includes no copied task data.

Only task output files now create artifact timeline announcements. Desktop also hides historical announcements for internal run artifacts.

Generated-By: PostHog Desktop
Task-Id: 4124a619-4b24-46e5-85ea-016b920ef6be
@puemos puemos self-assigned this Aug 14, 2026
@trunk-io

trunk-io Bot commented Aug 14, 2026

Copy link
Copy Markdown

😎 Merged successfully - details.

@github-actions github-actions Bot added the feature/desktop Feature Tag: Desktop label Aug 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit 81e268f.

@hosthog

hosthog Bot commented Aug 14, 2026

Copy link
Copy Markdown

HostHog preview — posthog-desktop-web

The previews for this PR have been torn down and no longer serve.

@posthog

posthog Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

🦔 ReviewHog reviewed this pull request

Nothing worth raising this time, so here's a calming picture instead:

A happy dog on a sunny path

@puemos puemos added the skip-desktop-backend-check Allow independent desktop and backend changes in one PR label Aug 14, 2026 — with PostHog
@trunk-io

trunk-io Bot commented Aug 14, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@puemos
puemos marked this pull request as ready for review August 14, 2026 11:44
@pr-assigner-resolver-posthog
pr-assigner-resolver-posthog Bot requested a review from a team August 14, 2026 11:45
@puemos puemos added the stamphog Request AI approval (no full review) label Aug 14, 2026

@stamphog stamphog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contained bug fix filtering internal artifact types (git checkpoints, skill bundles) out of the task timeline and out of version-counting logic; diff matches the description, includes matching tests on both sides, and touches no risky territory. Cross-team authorship is offset by the author's STRONG familiarity with all four changed files.

  • Author wrote 100% of the modified lines and has 19 merged PRs in these paths (familiarity STRONG).
Gate mechanics and policy version
Gate Result
prerequisites all clear
deny-list no deny categories matched
size 39L, 2F substantive, 81L/4F incl. docs/generated/snapshots — within ceiling
tier T1-agent / T1b-small (81L, 4F, single-area, fix)
stamphog 2.0.0b4 .stamphog/policy.yml @ 0b286b3 · reviewed head 81e268f

@trunk-io
trunk-io Bot merged commit dd328aa into master Aug 14, 2026
414 of 416 checks passed
@trunk-io
trunk-io Bot deleted the posthog/fix-internal-artifact-timeline-events branch August 14, 2026 12:50
@deployment-status-posthog

deployment-status-posthog Bot commented Aug 14, 2026

Copy link
Copy Markdown

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-08-14 13:21 UTC Run
prod-us ✅ Deployed 2026-08-14 13:59 UTC Run
prod-eu ✅ Deployed 2026-08-14 13:57 UTC Run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature/desktop Feature Tag: Desktop skip-desktop-backend-check Allow independent desktop and backend changes in one PR stamphog Request AI approval (no full review)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant