fix(agent): send scout chat runs to the signals gateway product - #84751
Merged
Conversation
Scout chat tasks carry the `signals_chat` origin, which `resolveGatewayProduct` did not map, so they fell through to `posthog_code`. Their tokens mint under the Signals OAuth application, which only the `signals` product authorizes, so every scout chat run would be rejected once a region has a Signals application row. Mapping the origin also puts these runs on the interactive Signals budget: the cost key resolves from the token's marker only when the declared product is `signals`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
😎 Merged successfully - details. |
Contributor
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
1 task
HostHog preview —
|
skoob13
changed the title
skoob13
marked this pull request as ready for review
August 19, 2026 07:53
Contributor
🤖 CI report✅ Trunk lane — does not run backend Python testsThis PR is assigned to a lane that does not run backend Python tests. |
Contributor
|
Reviews (1): Last reviewed commit: "fix(desktop/agent): send scout chat runs..." | Re-trigger Greptile |
|
Note 🤖 stamphog reviewed This adds a gateway-authorization mapping entry (which product/budget a token is minted and billed under) — billing/auth-adjacent risky territory — and the author is not on the owning desktop team, with only bot thumbs-up reactions and no actual APPROVED/COMMENTED review.
Gate mechanics and policy version
|
andrewm4894
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
signals_chatorigin, andresolveGatewayProducthas no entry for it.posthog_code, which a Signals-minted token does not authorize.Changes
resolveGatewayProductmapssignals_chatto thesignalsproduct, next tosignal_reportandsignals_scout.signals.signals_chatstill mints under the Array app, which authorizessignalsas well.How did you test this code?
Automated only, and I did not run it locally: the nested
products/desktopworkspace was not installed in my checkout, so CI is the first run ofgateway.test.tson this change.signals_chatfor bothisInternalvalues.posthog_code, which no other case covers.Automatic notifications
Docs update
None.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Claude Code (Opus 5) wrote this. Skills invoked:
/writing-pr-descriptions.The commit is cherry-picked unchanged from #84066, where the "Desktop backend coupling" check failed it. I verified the two halves are independent: no backend file in that PR references
signals_chat.