Skip to content

fix(tasks): forward saved feed filters - #85372

Merged
trunk-io[bot] merged 1 commit into
masterfrom
posthog/fix-task-feed-filters
Aug 19, 2026
Merged

fix(tasks): forward saved feed filters#85372
trunk-io[bot] merged 1 commit into
masterfrom
posthog/fix-task-feed-filters

Conversation

@puemos

@puemos puemos commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Problem

Saved-search users could see unpinned tasks because the app did not send the pin filter to the task-list API.

Changes

  • Saved searches now send pin, commenter, and mention filters to the task-list API.
  • Contradictory archive filters now return no tasks.
  • No screenshot: the existing saved-search UI has no visual change.

How did you test this code?

  • Added client request tests that catch saved-search filters being omitted from task-list requests.
  • Added a query-planner test that catches contradictory archive filters returning results.
  • Ran the desktop client and query-planner tests, type checks, formatting checks, and the backend task-filter matrix.

Automatic notifications

  • Publish to changelog?

Docs update

No documentation update needed. No documented workflow changed.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

  • Authored with PostHog Code tools.
  • Invoked /writing-tests and /writing-pr-descriptions.
  • The change forwards existing saved-search filters through the existing task-list API.

Forward pinned, commenter, and mention filters to the task-list API and preserve contradictory archive filter semantics.

Generated-By: PostHog Desktop
Task-Id: 7d8f53e8-3c0b-49b8-b573-8b41923db247
@trunk-io

trunk-io Bot commented Aug 19, 2026

Copy link
Copy Markdown

😎 Merged successfully - details.

@github-actions

Copy link
Copy Markdown
Contributor

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit dd34d4b.

@github-actions

Copy link
Copy Markdown
Contributor

🤖 CI report

Trunk lane — does not run backend Python tests

This PR is assigned to a lane that does not run backend Python tests.

@hosthog

hosthog Bot commented Aug 19, 2026

Copy link
Copy Markdown

HostHog preview — posthog-desktop-web

The previews for this PR have been torn down and no longer serve.

@trunk-io

trunk-io Bot commented Aug 19, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@puemos
puemos marked this pull request as ready for review August 19, 2026 12:30
@puemos puemos added the stamphog Request AI approval (no full review) label Aug 19, 2026
@pr-assigner-resolver-posthog
pr-assigner-resolver-posthog Bot requested a review from a team August 19, 2026 12:30

@stamphog stamphog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small, well-tested frontend fix within the owning team's area (author has strong familiarity, last-touched 100% of the modified lines); no risky territory and no unresolved concerns.

  • Author wrote 100% of the modified lines and has 9 merged PRs in these paths (familiarity STRONG).
Gate mechanics and policy version
Gate Result
prerequisites all clear
deny-list no deny categories matched
size 26L, 2F substantive, 60L/4F incl. docs/generated/snapshots — within ceiling
tier T1-agent / T1b-small (60L, 4F, single-area, fix)
stamphog 2.0.0b4 .stamphog/policy.yml @ dd34d4b · reviewed head dd34d4b

@puemos

puemos commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

/trunk merge

@puemos puemos added the create desktop release Auto-release desktop on merge: desktop-tag.yml tags, desktop-release.yml builds and ships label Aug 19, 2026
@trunk-io
trunk-io Bot merged commit 5688d4d into master Aug 19, 2026
329 checks passed
@trunk-io
trunk-io Bot deleted the posthog/fix-task-feed-filters branch August 19, 2026 14:03
@deployment-status-posthog

deployment-status-posthog Bot commented Aug 19, 2026

Copy link
Copy Markdown

Deploy status

Environment Status Deployed At Workflow
dev ✅ Deployed 2026-08-19 14:40 UTC Run
prod-us ✅ Deployed 2026-08-19 15:23 UTC Run
prod-eu ✅ Deployed 2026-08-19 15:21 UTC Run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

create desktop release Auto-release desktop on merge: desktop-tag.yml tags, desktop-release.yml builds and ships feature/desktop Feature Tag: Desktop stamphog Request AI approval (no full review)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant