feat(desktop): name the cohorts a cohort's criteria reference - #95640
Merged
trunk-io[bot] merged 2 commits intoSep 7, 2026
Merged
Conversation
Membership criteria read "Is in cohort Power users" instead of "Is in cohort 42". The cohort page fetches the referenced cohorts, capped at ten, and a failed lookup leaves the id in place. Generated-By: PostHog Desktop Task-Id: ceed37c8-d844-4534-ae64-976efe7c87f0
Contributor
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
🤖 CI report✅ Trunk lane — non-backend laneThis PR is assigned to the non-backend lane. It does not run backend Python tests and may merge in parallel with PRs in other lanes. |
Generated-By: PostHog Desktop Task-Id: ceed37c8-d844-4534-ae64-976efe7c87f0
puemos
marked this pull request as ready for review
September 6, 2026 06:16
adamleithp
approved these changes
Sep 7, 2026
Contributor
Author
|
/trunk merge |
|
😎 Stack merged successfully - details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the desktop app's cohort page, membership criteria that reference another cohort show its numeric id, for example "Is in cohort 42". A person cannot tell which cohort that is without opening PostHog.
Changes
cohortCriteriaSectionandshapeCohortPreviewtake a name map, and a newreferencedCohortIdshelper walks the criteria.Before, the same criteria read "Is in cohort 42 and ..." and "Is not in cohort 57 and ...".
How did you test this code?
Automatic notifications
Docs update
None.
🤖 Agent context
Built in a PostHog Desktop task as the top layer of a stack on #93987. Kept to name resolution; the cohort criteria were already prose. Skills invoked: stacking-prs, writing-tests, writing-pr-descriptions.
Created with PostHog Desktop