fix(tui): guard Tumblers pin geometry and re-enable Visualizer tab - #890
Merged
Conversation
Clamp each pin's target row to the cylinder interior and bounds-check grid
writes so the EnvSetup ("Wiring Up Secrets") visual no longer indexes a
negative row on short panels. Re-adds the Visualizer tab to RunScreen that
was removed to dodge the crash.
Generated-By: PostHog Code
Task-Id: 9da2b460-5d1c-417f-8c31-9eb684681fc6
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Results will be posted here when complete. |
… helper The Tumblers crash was one instance of a broader class: every phase visual built a raw character grid and did unguarded `grid[y][x] = ch` writes, so any miscomputed coordinate on a short/narrow panel could index an undefined row and crash the whole TUI. LibraryShelf had the same latent bug (negative `shelfY - 1` at small heights). Introduce a shared `grid.ts` (`createGrid` / `plot` / `writeText`) where an out-of-bounds coordinate is a silent no-op, and route every grid-based visual (Tumblers, LibraryShelf, CrateStack, DashboardGrid) through it so a geometry bug degrades to a cosmetic glitch instead of a crash. Also harden DiffCascade's line-buffer access against a resize. Adds unit tests covering the guarantee, including the exact negative-row case that produced the original error. Generated-By: PostHog Code Task-Id: 9da2b460-5d1c-417f-8c31-9eb684681fc6
Twixes
marked this pull request as ready for review
August 3, 2026 19:16
Collaborator
|
yayyyy!!! |
Twixes
enabled auto-merge (squash)
August 6, 2026 15:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Visualizer tab was crashing agent runs on short terminals (
Cannot set properties of undefined (setting '12')) and was removed in #787 to stop the bleeding. The team wants it back.Root cause: the
Tumblersvisual (EnvSetup / "Wiring Up Secrets") computed a pin's target row ascylinderBottom - 1 - (i % 3) - Math.floor(i / 2). On a short panel that can resolve above the top of the cylinder — even negative — and the value was stored as a settled height and then written back viagrid[negativeRow][pinX], indexing an undefined row and throwing.Changes
targetForPinto the cylinder interior ([cylinderTop, cylinderBottom]) so a pin can never settle above the top or below the floor.visualizertab entry (and itsVisualizerTabimport) toRunScreen.Test plan
pnpm buildpasses (incl. smoke + warlock smoke tests)pnpm lintclean (0 errors)Created with PostHog from a Slack thread