fix(tui): disable crashing Visualizer tab - #787
Merged
Conversation
The Visualizer tab crashes on short terminals ("Cannot set properties
of undefined (setting '12')"). Tumblers computes a negative pin row when
the panel is short and writes to grid[undefined]. Remove the tab entry
from RunScreen so the crash is unreachable; the animation code and the
playground demo are left intact for a proper bounds-guard fix later.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Results will be posted here when complete. |
edwinyjlim
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the Visualizer tab from the run screen. It crashes on short terminals with:
maybe why, this is what claude thinks, I need to verify :)
The
Tumblersvisual (the "Wiring Up Secrets" / EnvSetup phase) computes a pin's target row ascylinderBottom - 1 - (i % 3) - Math.floor(i / 2). When the visualizer panel is short (the tab clamps to a 5-6 row minimum), the 6th pin (i = 5) resolves to a negative row. That value is stored as a settled height and then written back viagrid[negativeRow][pinX]—grid[undefined], which throws.pinXfor that pin is12, hence the error text.Rather than land a rushed geometry fix, this just makes the crash unreachable by dropping the tab entry. The animation code and the playground demo are left intact so the underlying bounds bug can be fixed properly in a follow-up.
Changes
visualizerentry from thetabsarray inRunScreen.tsx(+ its now-unused import), with a comment pointing at the root cause.Follow-up
Add a negative/out-of-bounds row guard in
Tumblers.tsx(the sibling visuals already guard their grid writes), then re-enable the tab.Test plan
pnpm buildpasses (incl. smoke test)pnpm lintclean (0 errors)🤖 Generated with Claude Code