fix off by one error with ellipsis #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 29, 2020
Collaborator
|
Done. LGTM. Please do me a favor and try this:
I'd like your opinion on the new style for checked/selected. Ignore headers not being aligned. |
Member
Author
|
@tig I don't see anything for multiple!
same with Single:
|
Collaborator
|
What is the font you use? |
Member
Author
|
I use Fira Code with ligatures |
Collaborator
|
What if you try to select something (SPACE)? |
Member
Author
|
Nothing shows up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #104
I'm not sure why this was 4 before... maybe a typo... or maybe they thought the Substring was inclusive.... but anyway, this aligns things properly.
I'd love it if @tig could review/give my PR a try