Skip to content

Fix some dead links#8650

Closed
RDIL wants to merge 5 commits into
PowerShell:masterfrom
RDIL:patch-2
Closed

Fix some dead links#8650
RDIL wants to merge 5 commits into
PowerShell:masterfrom
RDIL:patch-2

Conversation

@RDIL

@RDIL RDIL commented Jan 15, 2019

Copy link
Copy Markdown
Contributor

PR Summary

Now that I added a link check task, I'm going to fix all the links it detects as broken!

PR Context

Dead links are bad links and bad links are bad documentation if that made any sense

PR Checklist

@RDIL
RDIL requested a review from joeyaiello as a code owner January 15, 2019 14:04
@RDIL

RDIL commented Jan 15, 2019

Copy link
Copy Markdown
Contributor Author

Static analysis come out wherever you are

@RDIL RDIL changed the title [ WIP ] Fix dead links Fix some dead links Jan 15, 2019
@RDIL

RDIL commented Jan 15, 2019

Copy link
Copy Markdown
Contributor Author

!wip refresh

Comment thread .github/CONTRIBUTING.md
[up-for-grabs]: https://github.com/powershell/powershell/issues?q=is%3Aopen+is%3Aissue+label%3AUp-for-Grabs
[semantic linefeeds]: http://rhodesmill.org/brandon/2012/one-sentence-per-line/
[PowerShell-Docs]: https://github.com/powershell/powershell-docs/
[use-vscode-editor]: ../docs/learning-powershell/using-vscode.md#editing-with-visual-studio-code

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, this file doesn't exist anymore.

@RDIL

RDIL commented Jan 15, 2019

Copy link
Copy Markdown
Contributor Author

macos failing question mark question mark

@TravisEz13

Copy link
Copy Markdown
Member

I may have duplicated some of this work. I created this PR to make the static analysis fail if there is a broken link:
#8653

@TravisEz13 TravisEz13 self-assigned this Jan 15, 2019
@RDIL RDIL closed this Jan 15, 2019
@RDIL
RDIL deleted the patch-2 branch January 15, 2019 20:35
@RDIL

RDIL commented Jan 15, 2019

Copy link
Copy Markdown
Contributor Author

Yeah it seems that way. I reviewed that PR.

@iSazonov iSazonov added the CL-NotInBuild Indicates that a PR is reverted and not part of the build. label Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-NotInBuild Indicates that a PR is reverted and not part of the build.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants