Kubecon Japan and KCD Vietnam landing page improvements - #649
Conversation
Signed-off-by: Reza Jelveh <fishmangit@dynamia.ai>
|
@fishman: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for project-hami ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Warning Review limit reached
Next review available in: 49 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdds slug-based event resolution and JSON-LD metadata to the shared landing component, introduces the KCD Vietnam page and event data, updates KubeCon Japan metadata, and renders localized outbound event and talk links. ChangesEvent landing updates
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant Visitor
participant LandingPage
participant EventLanding
participant EventData
Visitor->>LandingPage: Open event landing URL
LandingPage->>EventLanding: Pass event slug
EventLanding->>EventData: Resolve event record
EventLanding-->>Visitor: Render event page and JSON-LD
Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…n hero - Create KCD Vietnam landing page with event data and banner image - Display external URL and talk URL links in event hero section - Add externalUrl/talkUrl fields to KubeCon Japan event data Signed-off-by: Reza Jelveh <fishmangit@dynamia.ai>
Signed-off-by: Reza Jelveh <fishmangit@dynamia.ai>
…mensions Signed-off-by: Reza Jelveh <fishmangit@dynamia.ai>
6bb4d26 to
e81f4cd
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fishman The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
…LandingPage component fixes Project-HAMi#651 and Project-HAMi#653 Signed-off-by: Reza Jelveh <fishmangit@dynamia.ai>
5bb1d87 to
7ab1747
Compare
mesutoezdil
left a comment
mesutoezdil
left a comment
There was a problem hiding this comment.
left a few inline notes, nth blocking except the img one
…s data - Wrap component with Layout including page title/description/image metadata - Include address in structured data JSON-LD when available - Remove the now-unnecessary EventLandingPage component - Simplify landing page files to import EventLanding directly Signed-off-by: Reza Jelveh <fishmangit@dynamia.ai>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/EventLanding.js`:
- Around line 68-78: Move the useBaseUrl call before the !event early-return
branch in EventLanding, passing event?.banner ?? "" so the hook runs
consistently for valid and invalid events. Keep the existing not-found rendering
unchanged.
In `@src/pages/landing/kcd-vietnam.js`:
- Line 3: Rewrite all commits introduced since origin/master to include the
appropriate author Signed-off-by: trailer, using git commit --amend --no-edit or
equivalent history rewriting, then force-push the updated commit history.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 6776873a-6b72-4ca4-a355-eedda7a53474
⛔ Files ignored due to path filters (1)
static/img/events/2026-kcd-vietnam/from-project-to-production-hami-and-viettel-cloud_jelveh-nguyen.jpegis excluded by!**/*.jpeg
📒 Files selected for processing (5)
src/components/EventLanding.jssrc/components/EventLanding.module.csssrc/data/events.jssrc/pages/landing/kcd-vietnam.jssrc/pages/landing/kubecon-japan.js
🚧 Files skipped from review as they are similar to previous changes (2)
- src/data/events.js
- src/components/EventLanding.module.css
revert 1ca6306 Signed-off-by: Reza Jelveh <fishmangit@dynamia.ai>
7f87429 to
cd92680
Compare
Signed-off-by: Reza Jelveh <fishmangit@dynamia.ai>
|
/lgtm |
5 participants
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Fix the KCD and Kubecon landing pages
Summary by CodeRabbit