Skip to content

Update KubeCon Japan event metadata and add talk slides - #663

Merged
mesutoezdil merged 3 commits into
Project-HAMi:masterfrom
fishman:kcd-japan-update
Jul 28, 2026
Merged

Update KubeCon Japan event metadata and add talk slides#663
mesutoezdil merged 3 commits into
Project-HAMi:masterfrom
fishman:kcd-japan-update

Conversation

@fishman

@fishman fishman commented Jul 28, 2026

Copy link
Copy Markdown
Contributor
  • fix(events): correct OG image fallback and add KubeCon Japan talk slides
  • fix(EventLanding): set og:image from event banner via Head, use siteConfig.url

What type of PR is this?

/kind feature

What this PR does / why we need it:

fix eventlanding metadata(for linking, etc) and add KubeCon Japan talk slides

Summary by CodeRabbit

  • New Features
    • Added Talk Slides resources for the KubeCon Japan event, including English/Chinese labels and a PDF link.
    • Improved social sharing previews by generating event-specific Open Graph and Twitter image metadata when a banner image is available.
  • Bug Fixes
    • Ensured shared and Schema.org image URLs use the site’s configured base URL for correct absolute links.

Reza Jelveh added 2 commits July 29, 2026 01:47
Signed-off-by: Reza Jelveh <fishmangit@dynamia.ai>
…onfig.url

- Replace hardcoded domain with siteConfig.url in JSON-LD and og:image
- Set og:image via @docusaurus/Head instead of Layout image prop (SSR-only)
- Drop Layout image prop — not reliably forwarded for custom pages in dev

Signed-off-by: Reza Jelveh <fishmangit@dynamia.ai>
@hami-robot

hami-robot Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

@fishman: The label(s) kind/feature cannot be applied, because the repository doesn't have them.

Details

In response to this:

  • fix(events): correct OG image fallback and add KubeCon Japan talk slides
  • fix(EventLanding): set og:image from event banner via Head, use siteConfig.url

What type of PR is this?

/kind feature

What this PR does / why we need it:

fix eventlanding metadata(for linking, etc) and add KubeCon Japan talk slides

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@netlify

netlify Bot commented Jul 28, 2026

Copy link
Copy Markdown

Deploy Preview for project-hami ready!

Name Link
🔨 Latest commit b489f29
🔍 Latest deploy log https://app.netlify.com/projects/project-hami/deploys/6a68e5f996e5ff0008a2f6e0
😎 Deploy Preview https://deploy-preview-663--project-hami.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@hami-robot hami-robot Bot added the size/S label Jul 28, 2026
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Event landing pages now derive event image metadata from Docusaurus configuration and conditionally emit Open Graph and Twitter image tags. The kubecon-japan event also gains localized talk slides resource data.

Changes

Event updates

Layer / File(s) Summary
Event image metadata
src/components/EventLanding.js
Uses siteConfig.url for Schema.org image URLs and conditionally adds Open Graph and Twitter image tags when a banner URL exists.
KubeCon Japan talk slides
src/data/events.js
Adds localized talkSlides labels and a PDF URL to the kubecon-japan event resources.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested labels: enhancement

Suggested reviewers: wawa0210, mesutoezdil

Poem

I’m a rabbit with slides in my pack,
Bright event images hop on track.
With labels in two tongues,
Metadata sings,
And banners never look back.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main changes: KubeCon Japan metadata updates and a new talk slides resource.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

og:image was fixed but twitter:image still fell back to the site-wide
themeConfig image, so X/Twitter cards showed the generic logo instead of
the event banner.

Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
@mesutoezdil

Copy link
Copy Markdown
Contributor

/lgtm

@hami-robot

hami-robot Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fishman, mesutoezdil
Once this PR has been reviewed and has the lgtm label, please assign archlitchi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mesutoezdil mesutoezdil changed the title kcd japan update Update KubeCon Japan event metadata and add talk slides Jul 28, 2026
@mesutoezdil
mesutoezdil merged commit 414f6fa into Project-HAMi:master Jul 28, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants