Update KubeCon Japan event metadata and add talk slides - #663
Conversation
Signed-off-by: Reza Jelveh <fishmangit@dynamia.ai>
…onfig.url - Replace hardcoded domain with siteConfig.url in JSON-LD and og:image - Set og:image via @docusaurus/Head instead of Layout image prop (SSR-only) - Drop Layout image prop — not reliably forwarded for custom pages in dev Signed-off-by: Reza Jelveh <fishmangit@dynamia.ai>
|
@fishman: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for project-hami ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughEvent landing pages now derive event image metadata from Docusaurus configuration and conditionally emit Open Graph and Twitter image tags. The kubecon-japan event also gains localized talk slides resource data. ChangesEvent updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
og:image was fixed but twitter:image still fell back to the site-wide themeConfig image, so X/Twitter cards showed the generic logo instead of the event banner. Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fishman, mesutoezdil The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
fix eventlanding metadata(for linking, etc) and add KubeCon Japan talk slides
Summary by CodeRabbit