feat(landing): add Open Source Summit Korea event page - #748
Conversation
hami-robot
Bot
added
kind/documentation
✅ Deploy Preview for project-hami ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThe PR adds Open Source Summit Korea event metadata and a dedicated landing page. The shared event display now appends the event time zone when available. ChangesOpen Source Summit Korea event
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant Browser
participant OpenSourceSummitKoreaPage
participant EventLanding
participant eventsData
Browser->>OpenSourceSummitKoreaPage: request landing page
OpenSourceSummitKoreaPage->>EventLanding: render with opensource-summit-korea slug
EventLanding->>eventsData: load event metadata
eventsData-->>EventLanding: return event details and time zone
EventLanding-->>Browser: render event page with event times
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Reza Jelveh <fishmangit@dynamia.ai>
6efefbf to
d485eff
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/components/EventLanding.js (1)
117-117: 🗄️ Data Integrity & Integration | 🔵 Trivial | 🏗️ Heavy liftPropagate the time zone to the event JSON-LD.
Line 117 updates the HTML to show
11:40 - 12:10 KST, buteventJsonLd.startDateandendDatestill use date-only values. The emitted JSON-LD therefore loses the session time and offset. Schema.org permitsEvent.startDateandendDateto use ISO 8601DateTimevalues. (schema.org) Store a schema-compatible offset or full datetime in the event model, and use it for JSON-LD while retainingtimeZoneas the display label.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/EventLanding.js` at line 117, Update the event model and JSON-LD generation so eventJsonLd.startDate and endDate use schema-compatible ISO 8601 datetime values with the session time and offset, while retaining event.timeZone solely as the display label in the HTML.Source: MCP tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/data/events.js`:
- Line 170: Update the Open Source Summit Korea event entry’s talkUrl to the
session-specific HAMi talk page if available; otherwise, change the displayed
link label to “Schedule” so it does not present the general schedule as “Talk
Details.”
---
Nitpick comments:
In `@src/components/EventLanding.js`:
- Line 117: Update the event model and JSON-LD generation so
eventJsonLd.startDate and endDate use schema-compatible ISO 8601 datetime values
with the session time and offset, while retaining event.timeZone solely as the
display label in the HTML.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 4a897bf1-dc0c-4b19-b303-991f0ced9379
📒 Files selected for processing (3)
src/components/EventLanding.jssrc/data/events.jssrc/pages/landing/opensource-summit-korea.js
| githubUrl: "https://go.dynamia.ai/proj-hami-korea", | ||
| }, | ||
| externalUrl: "https://events.linuxfoundation.org/open-source-summit-korea/", | ||
| talkUrl: "https://events.linuxfoundation.org/open-source-summit-korea/program/schedule/", |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Repository files matching events/Event Landing:"
git ls-files | rg '(^|/)(events\.js|EventLanding\.(js|jsx|ts|tsx)|.*landing.*)$|src/data/events\.js' || true
echo
echo "src/data/events.js line count:"
wc -l src/data/events.js
echo
echo "Relevant src/data/events.js section:"
sed -n '140,200p' src/data/events.js
echo
echo "Find EventLanding references:"
rg -n "EventLanding|Talk Details|talkUrl|label.*Talk|link.*Talk" . --glob '!node_modules' --glob '!dist' --glob '!build' || trueRepository: Project-HAMi/website
Length of output: 4301
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "EventLanding relevant components:"
sed -n '100,160p' src/components/EventLanding.js
echo
echo "Check Linux Foundation URL headers/public availability without running repo code:"
python3 - <<'PY'
import urllib.request, urllib.error
urls = [
"https://events.linuxfoundation.org/open-source-summit-korea/program/schedule/",
"https://events.linuxfoundation.org/open-source-summit-korea/",
"https://coscup.org/2026/en/session/BGYZ3B",
"https://2026.vietopeninfra.org/en/#agenda",
]
for url in urls:
req = urllib.request.Request(url, headers={"User-Agent":"CodeRabbit-ReadonlyProbe/1.0"})
try:
with urllib.request.urlopen(req, timeout=10) as r:
info = r.info()
location = info.get("Location")
status = r.status
print(f"{url}\n status={status}\n location={location!r}\n")
except urllib.error.HTTPError as e:
print(f"{url}\n http_error={e.code}\n url_after_redirect={getattr(e, 'url', None)!r}\n")
except Exception as e:
print(f"{url}\n error={type(e).__name__}: {e}\n")
PYRepository: Project-HAMi/website
Length of output: 3664
Use a direct talk link or label this link Schedule.
EventLanding renders talkUrl as Talk Details, so users expect a session-specific page. For Open Source Summit Korea, talkUrl points to the general schedule instead of the HAMi talk page. Use the session URL when available; otherwise, rename the link to Schedule.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/data/events.js` at line 170, Update the Open Source Summit Korea event
entry’s talkUrl to the session-specific HAMi talk page if available; otherwise,
change the displayed link label to “Schedule” so it does not present the general
schedule as “Talk Details.”
Source: MCP tools
|
The text on the left is set to a maximum width of 720px, resulting in a lot of blank space on the right side on a widescreen. Although this may be for easier reading, it still feels like something is missing on the right side. |
|
It part of how the eventlanding was made. we can put an issue for that, but i'm not fixing it in this commit. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fishman, rootsongjc The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
2 participants
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Open Source Summit Korea
Summary by CodeRabbit