Skip to content

feat(reviewer): self-retracting verdicts (WO-3) - #257

Merged
ProtocolWarden merged 1 commit into
mainfrom
oc-watchdog/20260608-0645-wo3-self-retracting-verdicts
Jun 8, 2026
Merged

feat(reviewer): self-retracting verdicts (WO-3)#257
ProtocolWarden merged 1 commit into
mainfrom
oc-watchdog/20260608-0645-wo3-self-retracting-verdicts

Conversation

@ProtocolWarden

Copy link
Copy Markdown
Owner

Summary

  • "Needs human attention" and "Self-review concerns" comments are now automatically struck through when the blocking condition clears (PR merged, closed with receipt, or escalation cleared by a new push).
  • Root cause of 5 operator-confusion incidents on PRs # Spec authoring task #234, # Spec authoring task #243fix(custodian): disable built-in R1 line-budget detector to resolve ID collision #246: stale flag comments persisted on merged/resolved PRs with no automated cleanup.
  • Adds update_comment() to GitHubPRClient (PATCH issues/comments/:id).
  • Adds _retract_flag() helper; stores comment IDs in per-PR state (escalation_comment_id, concerns_comment_id); retracts at merge, close-with-receipt, and escalation-cleared paths.
  • 8 new unit tests; 73/73 reviewer tests pass; 15/15 golden tests pass; ruff + ty clean.

Test plan

  • CI passes (ruff, ty, pytest, custodian-audit)
  • Review watcher processes the PR via the normal review gate

🤖 Generated with Claude Code

"Needs human attention" and "Self-review concerns" comments are now
automatically struck through when the blocking condition clears: PR
merged, PR closed with receipt, or escalation cleared by a new push.

Root cause of 5 operator-confusion incidents: stale flag comments
persisted on merged/resolved PRs indefinitely.

- Add `update_comment()` to GitHubPRClient (PATCH issues/comments/:id)
- Add `_retract_flag()` helper to reviewer; edit comment in-place with
  strikethrough header and resolution annotation
- `_escalate_needs_human()` now stores `escalation_comment_id` in state
- First CONCERNS post stores `concerns_comment_id` in state
- Retraction sites: merge, close-with-receipt, escalation-cleared paths
- 8 new tests; 73/73 reviewer tests pass; 15/15 golden tests pass

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ProtocolWarden
ProtocolWarden merged commit 44538d1 into main Jun 8, 2026
17 checks passed
@ProtocolWarden
ProtocolWarden deleted the oc-watchdog/20260608-0645-wo3-self-retracting-verdicts branch June 8, 2026 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant