Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staged nightly #341

Merged
merged 85 commits into from
Jul 15, 2019
Merged

Staged nightly #341

merged 85 commits into from
Jul 15, 2019

Conversation

pm-shashank-jain
Copy link
Collaborator

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

Jaimin Panchal and others added 30 commits May 22, 2019 16:48
* added property ex to rawBid

* removed utils.getTopWindowUrl()
* - Updated the test ad unit to use 'telaria' as the bidder code.
- Added an example URL.

* using the bidder code constant
Explicit native.image.sizes in doc
* addressed feedback from prebid#3731 ticket

* removed commented code from emx test spec

* logging removed from spec

* flip h & w values from playerSize for video requests

* adding Outstream mediaType to EMX Digital
* auction key limiter feature - initial commit

* Updated config name
* aardvark tdid support

* increase aardvark test coverage
* native support & minor changes

* native support & minor changes

* increase test coverage

* fix win price value

* fix win price value tests

* fix alias, fix bidfloor

* remove alias

* use currency.adServerCurrency

* update version
* adxcgBidAdapter - added pubcid

* mini fix

* Update adxcgBidAdapter

Added minimal change to restart CI process

* added passing tdid, updated pubcid

* unit test for userid support - pubcid, tdid

* Update adxcgBidAdapter.js

just to restart CircleCI

* Update adxcgBidAdapter.js 

just to restart CircleCI
…rebid#3845)

* getCpmInNewCurrency to use current value of bid.cpm and bid.currency

* added a test case for boosted bid, this test fails with old code
add size 288 (640x380)
* initial orbidder version in personal github repo

* use adUnits from orbidder_example.html

* replace obsolete functions

* forgot to commit the test

* check if bidderRequest object is available

* try to fix weird safari/ie issue

* ebayK: add more params

* update orbidderBidAdapter.md

* use spec.<function> instead of this.<function> for consistency reasons

* add bidfloor parameter to params object

* fix gdpr object handling

* default to consentRequired: false when not explicitly given

* wip - use onSetTargeting callback

* add tests for onSetTargeting callback

* fix params and respective tests
- The global Prebid.js object name can be something other than 'pbjs'. Update log messages to reference the specified prebid global object name.
* Initial checkin with submodule support for DigiTrust.

* Addition of simple example file

* DigiTrust submodule now functioning with new userId system.

* Addition of Full example and confirming to work with or without DigiTrust library.

* Update based upon code review requests.

* Revert "Initial checkin with submodule support for DigiTrust."

This reverts commit c1fc37a.

# Conflicts:
#	modules/digiTrustIdSystem.js
#	modules/digiTrustIdSystem.md
* changed name company

* changed name company in test
* initial dev

* fix staq adapter name

* fix hello world staq call

* get hello world working again

* add user agent collection

* fix some unite tests

* Add STAQ Analytics Adapter doc

* clean up hello world

* fix tests to play nice with browserstack

* fix around issues with browserstack and deep equals of objects

* dump variable env testing since we can't mod user agent stuff in browserstack

* Update STAQ adapter to stop using deprecated utils for referrer

* remove package-lock.json changes via master rebase

* improve call frequency for ref util

* change ajax content type

* adjust ajax request to not expect whitelisting

* remove superflous commented-out code
msm0504 and others added 29 commits June 21, 2019 14:23
…3935)

* Add microadBidAdapter

* Remove unnecessary encodeURIComponent from microadBidAdapter

* Submit Advangelists Prebid Adapter

* Submit Advangelists Prebid Adapter 1.1

* Correct procudtion endpoint for prebid

* - Get digitrust data from bid request
- Send UnifiedID and PubCommon data to OpenRTB

* - Replace lodash with Prebid util functions
- Updated pubcommon id location when sending to OpenRTB

* Remove pref property when sending DigiTrust to OpenRTB

* Updated tests to check new user external id locations in request

* Remove use of array find from unit test
* Extract GDPRApplies in userId.js to make it available to cookie-sync requiring it

* Adding id5 userId submodule, tests and documentation

* Fixed typo in test name for unifiedid

* Adding test to userId for ID5

* Follow correct naming convention for GDPRApplies: renamed to isGDPRApplicable

* Refactoring of id5 module following refactoring of userId module.

* Moved init of id5 user module at the end of the id5 module itself

* regroup import to avoid a CircleCI Bug
* EMX Digital - device info and video parameter updates

* update timeout value to grab from bidderRequest arg

* removing unused import

* removing object spread use. quote fix for lint

* remove space
* fix return of _mapAdUnitPathToElementId()

* improve logging of _mapAdUnitPathToElementId()

* do not use Array.find()

* return id once element is found

* return id once element is found

* let -> const
* Added bidglass adapter + test

* PR Review Updates:

- Added formal params to getUserSyncs function definition
- getUserSyncs now always returns an array
- Improved unit test coverage

* PR Review Updates:

- Removed unused methods: getUserSyncs, onTimeout, onBidWon,
onSetTargeting
- Removed getUserSyncs unit test
- Removed "dead code"
- Removed some unnecessary comments
- Fixed usage of parseInt
* Implemented changes required to provide support for video in the IX bidding adapter for Instream and Outstream contexts.

* Implemented changes required to provide support for video in the IX bidding adapter for Instream and Outstream contexts.

* fix find module
* Add Outstream Renderer

* Fix playerSize overwrite

Prebid is translating the playerSize to an array of arrays, so we have to return accordingly
* Add microadBidAdapter

* Remove unnecessary encodeURIComponent from microadBidAdapter

* Submit Advangelists Prebid Adapter

* Submit Advangelists Prebid Adapter 1.1

* Correct procudtion endpoint for prebid

* Send coppa flag on requests to OpenRTB from Prebid server

* Support coppa flag being set in Prebid config

* Add unit tests for deepSetValue util function
…rebid#3916)

* bug fix for multi bids + GDPR parameter handling

* Updated spec files and adapter files to remove references to ozoneData and more stringent GDPR checks.
This reverts commit 7b70c14.
Updating for the new safe frame issue discovered, see prebid/prebid-universal-creative#64 for more details!
* Update emoteevBidAdapter.js

Retrieve various data from the adapter configuration, and ensure they
are properly formatted:
- GDPR vendor consent
- Metadata: intended to be used as an ID for external partners
- Context: describe the context of the current ad unit

Test coverage for emoteevBidAdapter.js:
- Statements 94.83%
- Branches 98.39%
- Functions 100%
- Lines 94.34%

fixup! Update emoteevBidAdapter.js

* remove pubCommonId import from emoteevBidAdapter

* Format indentation

* More detailed integration page example

* Rename attribute to externalId

* Simplify names of constants

* Minor tweak

* Update context value
* prebid-core only contains src and a few node_modules

* add back removed neverBundle to webpack build

* add module and submodule hooks

* allow vargs for submodules for flexibility

* fix jsdoc type syntax

* updated id5 userid submodule for submodule bundle size duplication fix

* add id5 userid submodule to .submodules

* fix opt out logic

* spelling fix to comment

* update to automatically include 'pubcommon' and 'unifiedid' (uncomment to optional submodule for prebid3.0)

* additional update to automatically include 'pubcommon' and 'unifiedid'

* additional update to automatically include 'pubcommon' and 'unifiedid'

* merged differences from master

* adpod changes to support submodules

* fix --modules argument with .json to work correctly with submodules

* fix to remove included and duplicated submodules
* Add support for multi-format ad units. Add favoredMediaType property to params.

* Add tests for gdpr consent.

* Add adId to outbids

* Modify media type resolving

* Refactor multi-format ad units handler.

* Add adasta - new bidder alias for gamoshi

* Unify rtb endpoints

* Modify adasta alias code
* Added bid adapter for seedtag

* Revert changes to package-lock

* added safe check
* check gdpr in buildRequest

* User sync based on whether gdpr applies or not

* check if consent data exists during user sync

* split user sync into further branches: 1) when gdpr does not apply 2) when consent data is unavailable

* contribute viewability to ttxRequest

* update tests

* remove window mock from tests

* use local variables

* introduce ServerRequestBuilder

* add withOptions() method to ServerRequestBuilder

* add semicolons

* sync up package-lock.json with upstream/master

* stub window.top in tests

* introduce getTopWindowSize() for test purpose

* reformat code

* add withSite() method to TtxRequestBuilder

add withSite() method to TtxRequestBuilder

* add isIframe() and _isViewabilityMeasurable()

* handle NON_MEASURABLE viewability in nested iframes

* consider page visibility, stub utils functions getWindowTop() and getWindowSelf()

* contribute viewability as 0 for inactive tab

* add prebidjs version to ttx request

* send caller as an array

* fix JSDoc in utils.js

* send viewability as non measurable when unable to locate target HTMLElement, add warning message

* introduce mapAdSlotPathToElementId()

* introduce getAdSlotHTMLElement(), add logging

* introduce mapAdSlotPathToElementId()

* update logging in ad unit path to element id mapping

* rephrase logging, fix tests

* update adapter documentation

* remove excessive logging

* improve logging

* revert change

* fix return of _mapAdUnitPathToElementId()

* improve logging of _mapAdUnitPathToElementId()

* do not use Array.find()

* return id once element is found

* return id once element is found

* let -> const

* Removing killswitch behavior for GDPR

* Updated comments to reflect current gdpr logic

* URI encode consent string

* Updated example site ID to help Prebid team e2e test our adapter
…20190703105042

Prebid upgrade 2 22 0 20190703105042
@pm-shashank-jain pm-shashank-jain merged commit 976c2e3 into nightly Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet