Bootstrap: CallArgv LLVM global leaks across JIT Context — bootstrap-aot-link segfault (#197)

[PurHur]

Problem

make bootstrap-aot-link fails: every AOT fixture compile segfaults (exit 139) in Runtime::standalone() → JITContext construction.

Root cause: CallArgv::$htGlobal is a process-wide static initialized on the first LLVM module, but nested JIT helper compilation during defineBuiltins() (e.g. WeakRefRegistryRuntime::ensureJitHelperCompiled) can emit CallArgv::emitStore() on a different JIT\Context module. FFI then passes incompatible LLVMOpaqueValue* handles (LLVMBuildStore / segfault).

Reference pattern

LateStaticBindingGlobals already guards with $classIdModule — static Value must not leak across Context instances.

Repro

source script/php-env.sh
php bin/compile.php -o /tmp/echo_hello test/bootstrap-aot/echo_hello.php
# Segmentation fault (core dumped), exit 139

EMBED mode surfaces the FFI error:

FFI\Exception: Passing incompatible argument 3 of C function 'LLVMBuildStore' ...
#0 lib/JIT/Builtin/CallArgv.php(38)

Done when

• php bin/compile.php -o /tmp/echo_hello test/bootstrap-aot/echo_hello.php succeeds
• make bootstrap-aot-link green (or first failing fixture documented if separate)
• Existing func_get_args JIT tests still pass

Refs #197, #10916, #1492

[PurHur]

claim: cursor-agent-lane-b — bootstrap-aot-link segfault (CallArgv static global cross-context leak; batch issue #14459)

[PurHur]

claim: cursor-agent-lane-c — batch (issue #14459). Note: prior claim from cursor-agent-lane-b is cross-lane (#14459 % 3 == 2 → lane C); no open PR observed — proceeding as lane C owner.

[PurHur]

Handoff — partial fix pushed, bootstrap-aot-link still red

PR: (opening now) — CallArgv module-guard only.

Fixed (this PR)

CallArgv::$htGlobal static leak across LLVM modules — pattern from LateStaticBindingGlobals.

Remaining blocker (not in this PR)

Standalone AOT init still segfaults (139) in CliArgvRuntime::implementStoreArgv() inside Context::ensureFullStandaloneBodies(), after ensureJitHelperCompiled succeeds.

Repro:

source script/php-env.sh
PHP_COMPILER_JIT_BUILTIN_TRACE=1 php bin/compile.php -o /tmp/t test/bootstrap-aot/echo_hello.php
# last trace: jit-cliargv: implementStoreArgv → segfault

make bootstrap-selfhost-link / bin/jit.php remain green (prelinked gen-0 / MCJIT embed path).

Next: file/follow CliArgvRuntime standalone __phpc_cli_store_argv LLVM emit issue or extend #14459 scope.

[PurHur]

claim: PHP Runtime → PHP — batch (issue #14459 CallArgv cross-context LLVM global leak)

[PurHur]

Merged via #14461.

Verification:

• php vendor/bin/phpunit test/unit/CallArgvGlobalsTest.php — OK (1 test)
• php bin/compile.php -o /tmp/echo_hello test/bootstrap-aot/echo_hello.php — exit 0
• make bootstrap-selfhost-vm-driver-execute-probe — OK

[PurHur]

Worker lane C — PR opened (cursor-agent-lane-c)

PR: (see gh pr list --head agent/issue-14459-callargv-context-leak)

Fixed

• Issue repro php bin/compile.php -o /tmp/echo_hello test/bootstrap-aot/echo_hello.php — exit 0 (was segfault 139)
• Root cause: CallArgv::$htGlobal leaked across LLVM modules + reentrant loadJitContext() during nested helper JIT in defineBuiltins()
• PHP implementation: lib/JIT/Builtin/CallArgv.php (ensureGlobal per module), lib/Runtime.php (claimJitContextSlot), bootstrap thin standalone init in lib/JIT/Context.php

Verification

source script/php-env.sh
php bin/compile.php -o /tmp/echo_hello test/bootstrap-aot/echo_hello.php  # exit 0
./vendor/bin/phpunit test/unit/BootstrapAotEchoCompileTest.php test/unit/CallArgvContextModuleTest.php  # OK

Handoff (not merging yet)

• make bootstrap-aot-link: compile-phase segfault largely gone, but ~47 output mismatch / ~36 compile failed remain on master+branch (AOT echo_hello binary is empty stdout on harness host)
• Next: standalone echo/output under bootstrap thin init, or finish full ensureFullStandaloneBodies() nested-JIT path with CallArgv + reentrancy fix only (no thin defer)