Fix CallArgv lazy init blocking spine/AOT compile (#197)#10916
Merged
Conversation
…als (#197). Native::call emits CallArgv storage on every user-function LLVM call; implement() was only invoked from Type::ensureExternals, so spine/AOT compile aborted with "CallArgv global not initialized" at c:main_before_php. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Native::call()always emitsCallArgv::emitStore()for func_get_args/func_num_args support (Language: Variadic functions (...$args) and func_get_args() #197), butCallArgv::implement()was only reached viaType::ensureExternals().c:main_before_phpwithLogicException: CallArgv global not initialized.emitStore()/load()(idempotentimplement()), matching other JIT helper patterns.Verification
Bootstrap fallback context:
make bootstrap-loop-probewas red on lib spine smoke due to this compile abort; full loop-probe still blocked on separate native parseAndCompile null + stale sidecar (#8559).Refs #1492, #197
Made with Cursor