internal: add safety comments in conversions (smallvec, path, vec) - #6259
Merged
Conversation
alex
approved these changes
Jul 29, 2026
alex
enabled auto-merge
July 29, 2026 01:32
Member
|
thanks! |
This was referenced Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #5487, continuing from #6256.
Removes the
#![allow(clippy::undocumented_unsafe_blocks)]exemption from three conversion files, each containing a single unsafe block, and adds// SAFETY:comments:src/conversions/smallvec.rssrc/conversions/std/path.rssrc/conversions/std/vec.rsOne commit per file for easier review. Happy to split into separate PRs if preferred.
Disclosure: I used AI assistance while analyzing this code; I have personally verified each safety argument against the documented contract of the API being called.