Fix: properly assign status to non-committable assets in mixed asset set - #1766
Merged
Conversation
…ts (#1644) At a rolling-horizon window seam, non-committable generators/links/processes carry no commitment status, so c.da.status returned 0 for them. This zeroed their ramp allowance and flipped the shut-down ramp term, producing impossible ramp bounds and spurious infeasibility when the network mixed committable and non-committable components. Gate s_init with c.da.committable so non-committable components are treated as always on (status=1) at the seam.
luciana-marques
approved these changes
Jun 30, 2026
luciana-marques
left a comment
luciana-marques
left a comment
There was a problem hiding this comment.
Nice catch! We did have (a lot of) infeasibilities related to ramping in our workflow, but I have not thought it could be a matter of having committable and non-committable units in the rolling horizon approach. To test this we would need to change the version of pypsa (we are thinking about doing it, but it all depends on the time we have). I will keep you posted. Thanks!
lkstrp
previously requested changes
Jun 30, 2026
Mirror the s_init seam fix to s_init_ext so extendable non-committable assets are treated as online at rolling-horizon seams. Fold the two seam regression tests into one parametrized test.
fneum
approved these changes
Jul 13, 2026
fneum
enabled auto-merge (squash)
July 13, 2026 10:26
FabianHofmann
dismissed
lkstrp’s stale review
July 14, 2026 10:48
addressed. approval by fneum instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1644
Changes proposed in this Pull Request
When a network has both committable and non-committable assets with ramp limits, rolling-horizon optimization with unit commitment can lead to false-positive infeasibility. This is caused as
statusdefault 0, is propagated to non-commitables and not correctly set to 1 - meaning they were treated as turned off in each horizon. The fix treats non-committable components as always "on".Checklist
docs.docs/release-notes.mdof the upcoming release is included.