Skip to content

Conversation

@Ongion
Copy link
Contributor

@Ongion Ongion commented May 15, 2024

This change adds documentation for the API function reset_consumable.

It adds information about the format of parameters for the function.

Copy link
Collaborator

@humbertogontijo humbertogontijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Collaborator

@humbertogontijo humbertogontijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually you might need to change commit message

@Ongion Ongion changed the title Update documentation for reset_consumable chore: Update documentation for reset_consumable May 16, 2024
@Ongion
Copy link
Contributor Author

Ongion commented May 16, 2024

Oh, I guess the commit message needs to have "chore:" as a prefix? Gimme a sec and I'll amend that...

Document parameter for API function reset_consumable
@Ongion Ongion force-pushed the reset-consumable-documentation branch from 2d963a1 to 800f8b6 Compare May 16, 2024 14:47
@Ongion
Copy link
Contributor Author

Ongion commented May 16, 2024

Alright, commit message amended

@humbertogontijo humbertogontijo merged commit 4071538 into Python-roborock:main May 16, 2024
ricopinazo added a commit to ricopinazo/python-roborock that referenced this pull request Jun 28, 2024
* fix: handle weird clean record response (Python-roborock#206)

* 2.2.2

Automatically generated by python-semantic-release

* chore: Update documentation for reset_consumable (Python-roborock#207)

Document parameter for API function reset_consumable

* chore: add load multi map parameter to docs(Python-roborock#209)

* S8 maxv highest mop intensity setting (Python-roborock#210)

* fix: s8 maxv has a wash and fill dock (Python-roborock#213)

* 2.2.3

Automatically generated by python-semantic-release

* S8MaxVUltra is missing some code mappings (Python-roborock#214)

* fix: add missing smart mode for s8 maxv dock

* fix: add missing modes for s8 maxv ultra

* fix: add missing modes for s8 maxv ultra

* feat: add warning in web requests if it fails to decode (Python-roborock#215)

* 2.3.0

Automatically generated by python-semantic-release

* feat: add some missing codes and make warnings only message once (Python-roborock#218)

* 2.4.0

Automatically generated by python-semantic-release

* feat: add some typing (Python-roborock#219)

* 2.5.0

Automatically generated by python-semantic-release

---------

Co-authored-by: Luke Lashley <conway220@gmail.com>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Benjamin Paul [MSFT] <benjamin.ian.paul@gmail.com>
Co-authored-by: PatrikTheDev <svob.pata@gmail.com>
Co-authored-by: Ethem Cem Özkan <ethemcem.ozkan@gmail.com>
Co-authored-by: Willy <168727804+user-08-151@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants