S8MaxVUltra is missing some code mappings #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humbertogontijo
approved these changes
Jun 6, 2024
Collaborator
|
Looks good |
ricopinazo
added a commit
to ricopinazo/python-roborock
that referenced
this pull request
Jun 28, 2024
* fix: handle weird clean record response (Python-roborock#206) * 2.2.2 Automatically generated by python-semantic-release * chore: Update documentation for reset_consumable (Python-roborock#207) Document parameter for API function reset_consumable * chore: add load multi map parameter to docs(Python-roborock#209) * S8 maxv highest mop intensity setting (Python-roborock#210) * fix: s8 maxv has a wash and fill dock (Python-roborock#213) * 2.2.3 Automatically generated by python-semantic-release * S8MaxVUltra is missing some code mappings (Python-roborock#214) * fix: add missing smart mode for s8 maxv dock * fix: add missing modes for s8 maxv ultra * fix: add missing modes for s8 maxv ultra * feat: add warning in web requests if it fails to decode (Python-roborock#215) * 2.3.0 Automatically generated by python-semantic-release * feat: add some missing codes and make warnings only message once (Python-roborock#218) * 2.4.0 Automatically generated by python-semantic-release * feat: add some typing (Python-roborock#219) * 2.5.0 Automatically generated by python-semantic-release --------- Co-authored-by: Luke Lashley <conway220@gmail.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Benjamin Paul [MSFT] <benjamin.ian.paul@gmail.com> Co-authored-by: PatrikTheDev <svob.pata@gmail.com> Co-authored-by: Ethem Cem Özkan <ethemcem.ozkan@gmail.com> Co-authored-by: Willy <168727804+user-08-151@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With current release (i.e adding the dock from #213) following warn messages appear within home assistant:
Following PR adds the missing code mappings.
RoborockDockWashTowelModeCode
RoborockMopIntensityS8MaxVUltra
RoborockFanSpeedS8MaxVUltra
