Skip to content

Conversation

@Lash-L
Copy link
Collaborator

@Lash-L Lash-L commented Jun 7, 2024

No description provided.

Copy link
Collaborator

@humbertogontijo humbertogontijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lash-L Lash-L merged commit 6ae69e9 into main Jun 7, 2024
@Lash-L
Copy link
Collaborator Author

Lash-L commented Jun 24, 2024

Using this to message you to ask @humbertogontijo -

I've been a bit overwhelmed with the core integration for Roborock and so I was going to look around asking for help. I was wondering if you wanted me to remove you from the codeowners on the core integration as I know that's never really been something that you signed up for and you get pinged for every new issue. And I figure I might have better luck getting more codeowners to sign up if it just shows one person working on it

What are your thoughts?

@humbertogontijo
Copy link
Collaborator

Hey @Lash-L !
Those messages don't bother me too much.
I wish I could help more, but unfortunately I cant.
With that said, I agree with you. Since I never actively helped in core integration, I think it would make more sense to be removed.
I hope you find some codeowners to help you with the integration

ricopinazo added a commit to ricopinazo/python-roborock that referenced this pull request Jun 28, 2024
* fix: handle weird clean record response (Python-roborock#206)

* 2.2.2

Automatically generated by python-semantic-release

* chore: Update documentation for reset_consumable (Python-roborock#207)

Document parameter for API function reset_consumable

* chore: add load multi map parameter to docs(Python-roborock#209)

* S8 maxv highest mop intensity setting (Python-roborock#210)

* fix: s8 maxv has a wash and fill dock (Python-roborock#213)

* 2.2.3

Automatically generated by python-semantic-release

* S8MaxVUltra is missing some code mappings (Python-roborock#214)

* fix: add missing smart mode for s8 maxv dock

* fix: add missing modes for s8 maxv ultra

* fix: add missing modes for s8 maxv ultra

* feat: add warning in web requests if it fails to decode (Python-roborock#215)

* 2.3.0

Automatically generated by python-semantic-release

* feat: add some missing codes and make warnings only message once (Python-roborock#218)

* 2.4.0

Automatically generated by python-semantic-release

* feat: add some typing (Python-roborock#219)

* 2.5.0

Automatically generated by python-semantic-release

---------

Co-authored-by: Luke Lashley <conway220@gmail.com>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Benjamin Paul [MSFT] <benjamin.ian.paul@gmail.com>
Co-authored-by: PatrikTheDev <svob.pata@gmail.com>
Co-authored-by: Ethem Cem Özkan <ethemcem.ozkan@gmail.com>
Co-authored-by: Willy <168727804+user-08-151@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants